cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin A. Burton" <bur...@relativity.yi.org>
Subject Re: A Suggestion for Cocoon2 Store
Date Sun, 26 Mar 2000 12:43:28 GMT
Stefano Mazzocchi wrote:
> 
> Ricardo Rocha wrote:
> >
> > Interface org.apache.cocoon.components.Store defines
> > methods store(), hold() and remove() as void, not
> > throwing any exception.
> >
> > Since persistent stores (e.g. a filesystem-based store)
> > may generate errors (e.g. IOException) during these
> > operations, it makes sense to make the above methods
> > return boolean so that client classes are able to test
> > whether the operation actually succeeded even in
> > the absence of an exception.
> >
> > Note that this is the way java.io.File handles operations
> > such as delete(), createNewFile() or mkdirs()...
> >
> > What do you guys think?
> 
> +1

-1.  Don't return boolean just throw an Exception.  This isn't C and it
is proven that eventually people don't catch these.  

Throw a StoreException or something.

Kevin

-- 
Kevin A Burton (burton@apache.org)
http://relativity.yi.org
Message to SUN:  "Please Open Source Java!"
"For evil to win is for good men to do nothing."

Mime
View raw message