cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mike Engelhart <mengelh...@earthtrip.com>
Subject XSP session diffs
Date Fri, 18 Feb 2000 14:32:30 GMT
can please someone commit this before the next release:

Index: xml-cocoon/src/org/apache/cocoon/processor/xsp/xsp-java.xsl
===================================================================
RCS file: 
/home/cvspublic/xml-cocoon/src/org/apache/cocoon/processor/xsp/xsp-java.xsl,
v
retrieving revision 1.7
diff -r1.7 xsp-java.xsl
108c108
<         HttpSession session = request.getSession(true);
---
>         HttpSession session = request.getSession(false);


This change works fine with the current implementation of XSP.  The reason
the getSession call is there in the first place was so that XSP authors had
access to the "session" variable name from within <xsp:logic> tags.  They
still do but this way if the session hasn't been created by the author then
the session variable will be null.
Ricardo mistakenly(?) created an implicit session for every XSP page.   When
building real-world sites this is more often NOT the way you want to create
a session. Usually a session is created by calling getSession(true) at a
strategic point in the web application.  This change still allows access to
the "session" variable name though within the xsp page.


thanks,
Mike


Mime
View raw message