cocoon-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From reinh...@apache.org
Subject svn commit: r530289 - in /cocoon/trunk/core/cocoon-store/cocoon-store-impl/src: changes/changes.xml main/resources/META-INF/cocoon/spring/cocoon-store-impl-ehcache.xml
Date Thu, 19 Apr 2007 07:04:02 GMT
Author: reinhard
Date: Thu Apr 19 00:04:01 2007
New Revision: 530289

URL: http://svn.apache.org/viewvc?view=rev&rev=530289
Log:
implement result of discussions with Vadim and Ard: don't use StoreJanitor together with EHCache
which would lead to unexpected behaviour very likely

Modified:
    cocoon/trunk/core/cocoon-store/cocoon-store-impl/src/changes/changes.xml
    cocoon/trunk/core/cocoon-store/cocoon-store-impl/src/main/resources/META-INF/cocoon/spring/cocoon-store-impl-ehcache.xml

Modified: cocoon/trunk/core/cocoon-store/cocoon-store-impl/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/cocoon/trunk/core/cocoon-store/cocoon-store-impl/src/changes/changes.xml?view=diff&rev=530289&r1=530288&r2=530289
==============================================================================
--- cocoon/trunk/core/cocoon-store/cocoon-store-impl/src/changes/changes.xml (original)
+++ cocoon/trunk/core/cocoon-store/cocoon-store-impl/src/changes/changes.xml Thu Apr 19 00:04:01
2007
@@ -32,13 +32,14 @@
         MRUMemoryStore registers at StoreJanitor only in that case, if StoreJanitor
         is set as dependency. By default it is set.
       </action>  
-      <!--action dev="reinhard" type="fix"> I reverted this fix as we should vote on
this.
-        EHDefaultStore doesn't register at StoreJanitor anymore. The usage of
-        StoreJanitor to remove elements from EHDefaultStore was contra-productive,
+      <action dev="reinhard" type="fix">
+        The usage of  StoreJanitor to remove elements from EHDefaultStore was contra-productive,
         because EHCache provides its own invalidation mechanisms which are more
         sophisticated than the removal of random items. Find more information
-        at http://marc.info/?t=117563247800004&amp;r=1&amp;w=2.
-      </action-->            
+        at http://marc.info/?t=117563247800004&amp;r=1&amp;w=2. In order to use EHDefaultStore
+        again, we would need access to EHCache internals so that we don't remove the
+        wrong items.
+      </action>            
       <action dev="reinhard" type="add">
         Expose all configuration properties that EHCache provides via setter methods.
         Using them, EHDefaultStore can be completly configured in the Spring bean

Modified: cocoon/trunk/core/cocoon-store/cocoon-store-impl/src/main/resources/META-INF/cocoon/spring/cocoon-store-impl-ehcache.xml
URL: http://svn.apache.org/viewvc/cocoon/trunk/core/cocoon-store/cocoon-store-impl/src/main/resources/META-INF/cocoon/spring/cocoon-store-impl-ehcache.xml?view=diff&rev=530289&r1=530288&r2=530289
==============================================================================
--- cocoon/trunk/core/cocoon-store/cocoon-store-impl/src/main/resources/META-INF/cocoon/spring/cocoon-store-impl-ehcache.xml
(original)
+++ cocoon/trunk/core/cocoon-store/cocoon-store-impl/src/main/resources/META-INF/cocoon/spring/cocoon-store-impl-ehcache.xml
Thu Apr 19 00:04:01 2007
@@ -36,7 +36,6 @@
     <property name="maxMemObjects" value="${org.apache.cocoon.store.maxobjects}"/>
     <property name="useCacheDirectory" value="${org.apache.cocoon.store.use-cache-directory}"/>
     <property name="settings" ref="org.apache.cocoon.configuration.Settings"/>
-    <property name="storeJanitor" ref="org.apache.excalibur.store.StoreJanitor"/>
   </bean>
 
   <!--



Mime
View raw message