Return-Path: Delivered-To: apmail-cocoon-cvs-archive@www.apache.org Received: (qmail 97834 invoked from network); 2 Sep 2005 03:17:52 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 2 Sep 2005 03:17:52 -0000 Received: (qmail 89024 invoked by uid 500); 2 Sep 2005 03:17:51 -0000 Delivered-To: apmail-cocoon-cvs-archive@cocoon.apache.org Received: (qmail 88971 invoked by uid 500); 2 Sep 2005 03:17:51 -0000 Mailing-List: contact cvs-help@cocoon.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@cocoon.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list cvs@cocoon.apache.org Received: (qmail 88952 invoked by uid 99); 2 Sep 2005 03:17:50 -0000 X-ASF-Spam-Status: No, hits=-9.8 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [209.237.227.194] (HELO minotaur.apache.org) (209.237.227.194) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 01 Sep 2005 20:17:50 -0700 Received: (qmail 97802 invoked by uid 65534); 2 Sep 2005 03:17:50 -0000 Message-ID: <20050902031750.97801.qmail@minotaur.apache.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r266246 - /cocoon/branches/BRANCH_2_1_X/src/java/org/apache/cocoon/util/log/CocoonLogFormatter.java Date: Fri, 02 Sep 2005 03:17:50 -0000 To: cvs@cocoon.apache.org From: antonio@apache.org X-Mailer: svnmailer-1.0.5 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: antonio Date: Thu Sep 1 20:17:44 2005 New Revision: 266246 URL: http://svn.apache.org/viewcvs?rev=266246&view=rev Log: Improve FastDateFormat usage. Thanks to Vadim Gritsenko :-) Modified: cocoon/branches/BRANCH_2_1_X/src/java/org/apache/cocoon/util/log/CocoonLogFormatter.java Modified: cocoon/branches/BRANCH_2_1_X/src/java/org/apache/cocoon/util/log/CocoonLogFormatter.java URL: http://svn.apache.org/viewcvs/cocoon/branches/BRANCH_2_1_X/src/java/org/apache/cocoon/util/log/CocoonLogFormatter.java?rev=266246&r1=266245&r2=266246&view=diff ============================================================================== --- cocoon/branches/BRANCH_2_1_X/src/java/org/apache/cocoon/util/log/CocoonLogFormatter.java (original) +++ cocoon/branches/BRANCH_2_1_X/src/java/org/apache/cocoon/util/log/CocoonLogFormatter.java Thu Sep 1 20:17:44 2005 @@ -76,6 +76,7 @@ protected final static String TYPE_ROOTTHROWABLE_STR = "rootThrowable"; private static final String DEFAULT_TIME_PATTERN = "(yyyy-MM-dd) HH:mm.ss:SSS"; + private static final FastDateFormat dateFormatter = FastDateFormat.getInstance(DEFAULT_TIME_PATTERN); /** * Hack to get the call stack as an array of classes. The @@ -302,13 +303,9 @@ * @return the formatted string */ protected String getTime(final long time, String pattern) { - String result; - - if (pattern == null) { - pattern = DEFAULT_TIME_PATTERN; + if (pattern == null || DEFAULT_TIME_PATTERN.equals(pattern)) { + return dateFormatter.format(time); } - FastDateFormat format = FastDateFormat.getInstance(pattern); - result = format.format(time); - return result; + return FastDateFormat.getInstance(pattern).format(time); } }