cocoon-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anathan...@apache.org
Subject svn commit: r170680 - in /cocoon: blocks/unsupported/xsp/trunk/java/org/apache/cocoon/components/language/markup/Logicsheet.java trunk/status.xml
Date Tue, 17 May 2005 22:24:20 GMT
Author: anathaniel
Date: Tue May 17 15:24:19 2005
New Revision: 170680

URL: http://svn.apache.org/viewcvs?rev=170680&view=rev
Log:
Fixes http://issues.apache.org/bugzilla/show_bug.cgi?id=32934

XSP Block: Race condition could lead to duplicate application of same logicsheet
with spurious compilation errors or undefined runtime behaviour.

Modified:
    cocoon/blocks/unsupported/xsp/trunk/java/org/apache/cocoon/components/language/markup/Logicsheet.java
    cocoon/trunk/status.xml

Modified: cocoon/blocks/unsupported/xsp/trunk/java/org/apache/cocoon/components/language/markup/Logicsheet.java
URL: http://svn.apache.org/viewcvs/cocoon/blocks/unsupported/xsp/trunk/java/org/apache/cocoon/components/language/markup/Logicsheet.java?rev=170680&r1=170679&r2=170680&view=diff
==============================================================================
--- cocoon/blocks/unsupported/xsp/trunk/java/org/apache/cocoon/components/language/markup/Logicsheet.java
(original)
+++ cocoon/blocks/unsupported/xsp/trunk/java/org/apache/cocoon/components/language/markup/Logicsheet.java
Tue May 17 15:24:19 2005
@@ -49,7 +49,7 @@
  * @author <a href="mailto:ricardo@apache.org">Ricardo Rocha</a>
  * @author <a href="mailto:dims@yahoo.com">Davanum Srinivas</a>
  * @author <a href="mailto:ovidiu@cup.hp.com">Ovidiu Predescu</a>
- * @version CVS $Id: Logicsheet.java,v 1.3 2004/05/17 13:44:47 unico Exp $
+ * @version CVS $Id$
  */
 public class Logicsheet extends AbstractLogEnabled
 {
@@ -95,6 +95,32 @@
         }
     }
 
+    /**
+     * Return true if other logicsheet has the same system id.
+     */
+    public boolean equals(Object other)
+    {
+        if (other == this)
+            return true;
+        if (other == null)
+            return false;
+        if (!(other instanceof Logicsheet))
+            return false;
+        Logicsheet that = (Logicsheet)other;
+        return this.systemId.equals(that.systemId);
+    }
+
+    /**
+     * Return hash code value for logicsheet.
+     */
+    public int hashCode()
+    {
+        return this.systemId.hashCode();
+    }
+
+    /**
+     * Return system id which uniquely identifies logicsheet.
+     */
     public String getSystemId()
     {
         return this.systemId;

Modified: cocoon/trunk/status.xml
URL: http://svn.apache.org/viewcvs/cocoon/trunk/status.xml?rev=170680&r1=170679&r2=170680&view=diff
==============================================================================
--- cocoon/trunk/status.xml (original)
+++ cocoon/trunk/status.xml Tue May 17 15:24:19 2005
@@ -94,6 +94,7 @@
   <person name="Michael Melhem" email="michaelm@apache.org" id="MM"/>
   <person name="Stephan Michels" email="stephan@apache.org" id="SMS"/>
   <person name="John Morrison" email="morrijr@apache.org" id="JM"/>
+  <person name="Alfred Nathaniel" email="anathaniel@apache.org" id="AN"/>
   <person name="Steven Noels" email="stevenn@apache.org" id="SN"/>
   <person name="Christopher Oliver" email="coliver@apache.org" id="CO"/>
   <person name="Giacomo Pati" email="giacomo@apache.org" id="GP"/>
@@ -447,6 +448,10 @@
    </action>
   </release>
   <release version="2.1.8" date="TBD">
+    <action dev="AN" type="fix" fixes-bug="32934">
+      XSP Block: Race condition could lead to duplicate application of same logicsheet
+      with spurious compilation errors or undefined runtime behaviour.
+    </action>
     <action dev="VG" type="add">
       IncludeTransformer moved from the scratchpad into the core. It has following
       features:



Mime
View raw message