cocoon-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vgritse...@apache.org
Subject svn commit: r165681 - /cocoon/trunk/src/java/org/apache/cocoon/transformation/helpers/TextRecorder.java
Date Mon, 02 May 2005 20:40:31 GMT
Author: vgritsenko
Date: Mon May  2 13:40:31 2005
New Revision: 165681

URL: http://svn.apache.org/viewcvs?rev=165681&view=rev
Log:
remove one extra copying of characters.

Modified:
    cocoon/trunk/src/java/org/apache/cocoon/transformation/helpers/TextRecorder.java

Modified: cocoon/trunk/src/java/org/apache/cocoon/transformation/helpers/TextRecorder.java
URL: http://svn.apache.org/viewcvs/cocoon/trunk/src/java/org/apache/cocoon/transformation/helpers/TextRecorder.java?rev=165681&r1=165680&r2=165681&view=diff
==============================================================================
--- cocoon/trunk/src/java/org/apache/cocoon/transformation/helpers/TextRecorder.java (original)
+++ cocoon/trunk/src/java/org/apache/cocoon/transformation/helpers/TextRecorder.java Mon May
 2 13:40:31 2005
@@ -1,12 +1,12 @@
 /*
- * Copyright 1999-2004 The Apache Software Foundation.
- * 
+ * Copyright 1999-2005 The Apache Software Foundation.
+ *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -15,31 +15,33 @@
  */
 package org.apache.cocoon.transformation.helpers;
 
-import org.xml.sax.SAXException;
-
-
 /**
- * This class records SAX Events and generates a String from all
- * characters events
+ * This class records all character SAX events and creates a string
+ * from them.
  *
  * @author <a href="mailto:cziegeler@s-und-n.de">Carsten Ziegeler</a>
- * @version CVS $Id: TextRecorder.java,v 1.3 2004/03/05 13:03:00 bdelacretaz Exp $
+ * @version $Id$
 */
-public final class TextRecorder
-extends NOPRecorder {
+public final class TextRecorder extends NOPRecorder {
+
+    /**
+     * Buffer collecting all character events.
+     */
+    private StringBuffer buffer;
 
     public TextRecorder() {
         super();
+        this.buffer = new StringBuffer();
     }
 
-    private StringBuffer buffer = new StringBuffer();
-
-    public void characters(char ary[], int start, int length)
-    throws SAXException {
-        buffer.append(new String(ary, start, length));
+    public void characters(char ary[], int start, int length) {
+        this.buffer.append(ary, start, length);
     }
 
+    /**
+     * @return Recorded text so far, trimmed.
+     */
     public String getText() {
-        return buffer.toString().trim();
+        return this.buffer.toString().trim();
     }
 }



Mime
View raw message