cocoon-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jo...@apache.org
Subject svn commit: r106296 - /cocoon/trunk/src/blocks/forms/java/org/apache/cocoon/forms/datatype/DefaultSelectionListBuilder.java
Date Tue, 23 Nov 2004 13:19:55 GMT
Author: joerg
Date: Tue Nov 23 05:19:52 2004
New Revision: 106296

Modified:
   cocoon/trunk/src/blocks/forms/java/org/apache/cocoon/forms/datatype/DefaultSelectionListBuilder.java
Log:
fixed possible NPE

Modified: cocoon/trunk/src/blocks/forms/java/org/apache/cocoon/forms/datatype/DefaultSelectionListBuilder.java
Url: http://svn.apache.org/viewcvs/cocoon/trunk/src/blocks/forms/java/org/apache/cocoon/forms/datatype/DefaultSelectionListBuilder.java?view=diff&rev=106296&p1=cocoon/trunk/src/blocks/forms/java/org/apache/cocoon/forms/datatype/DefaultSelectionListBuilder.java&r1=106295&p2=cocoon/trunk/src/blocks/forms/java/org/apache/cocoon/forms/datatype/DefaultSelectionListBuilder.java&r2=106296
==============================================================================
--- cocoon/trunk/src/blocks/forms/java/org/apache/cocoon/forms/datatype/DefaultSelectionListBuilder.java
(original)
+++ cocoon/trunk/src/blocks/forms/java/org/apache/cocoon/forms/datatype/DefaultSelectionListBuilder.java
Tue Nov 23 05:19:52 2004
@@ -137,10 +137,10 @@
 
             return selectionListElement;
         } finally {
-            if (source != null) {
-                resolver.release(source);
-            }
             if (resolver != null) {
+                if (source != null) {
+                    resolver.release(source);
+                }
                 serviceManager.release(resolver);
             }
         }

Mime
View raw message