cloudstack-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chiradeep Vittal <Chiradeep.Vit...@citrix.com>
Subject Re: [cloudmonkey] username / password support
Date Thu, 17 Oct 2013 01:25:39 GMT
Fixed pep8 and other issues (with flake8).

Does this warrant a new release?

On 10/16/13 11:13 AM, "Chiradeep Vittal" <Chiradeep.Vittal@citrix.com>
wrote:

>Passwords can be changed too. No difference in security, IMO.
>
>Plus the api key option is always there.
>
>In fact I first wrote it as an option ( --populate-api-keys
>USERNAME:PASSWORD), but decided that it didn't buy anything.
>
>The original code didn't pass pep8 (imports not being used etc), that's
>probably a separate patch.
>
>
>-----Original Message-----
>From: rohityadav89@gmail.com [mailto:rohityadav89@gmail.com] On Behalf Of
>Rohit Yadav
>Sent: Wednesday, October 16, 2013 10:50 AM
>To: dev@cloudstack.apache.org
>Cc: users@cloudstack.apache.org
>Subject: Re: [cloudmonkey] username / password support
>
>I never intended to have support for password as I thought people will
>end up using and storing plain text username/password, keys (specific for
>cloudmonkey) are revokable :)
>Maybe we can use usernames/password initially to create keys or maybe let
>users decided what they want. If this could be refactored as a reusable
>module Prasanna can use this for Marvin.
>
>On Wed, Oct 16, 2013 at 10:21 AM, Chiradeep Vittal <
>Chiradeep.Vittal@citrix.com> wrote:
>
>> Sorry, urllib2 and cookiejar looked just too painful.
>>
>
>Totally agree, we should throw away painful things for better ones. With
>requests as dependency in setup.py so no one has to install it manually.
>You just do pip install --upgrade stuff and pip would get all the deps
>from setup.py. Thanks Prasanna for adding that, maybe specify a minimum
>or maximum version?
>
>Initially my idea was to use least possible dependency, like have
>cloudmonkey pure python 2.6 program that just uses standard libs but
>eventually added prettytable and pygments. We should have more good
>stuff, remove painful libs.
>
>Lastly, could the code be pep8'd, tested and released :)
>
>Cheers,
>bhaisaab
>
>
>>
>> On 10/15/13 9:26 PM, "Prasanna Santhanam" <tsp@apache.org> wrote:
>>
>> >
>> >I fixed this temporarily by adding the requests as a dependency. But
>> >may be we could do the login using urllib2 itself to avoid the
>> >requests dependency.
>> >
>> >+1 to username,password login. I need to add that to marvin too.
>> >
>> >On Wed, Oct 16, 2013 at 11:38:40AM +0800, Ryan Lei wrote:
>> >> I was unable to run cloudmonkey after applying your update.
>> >> My commands were:
>> >>
>> >> $ git checkout username_password_support $ git pull $ python
>> >> setup.py build $ python setup.py install $ cloudmonkey
>> >>
>> >> Then I got this import error:
>> >> Import error in cloudmonkey.requester : No module named requests
>> >>
>> >> Switching back to master branch runs fine, however.
>> >>
>> >>
>> >>
>> >>--------------------------------------------------------------------
>> >>-----
>> >>------------------
>> >> Yu-Heng (Ryan) Lei, Associate Researcher  Chunghwa Telecom
>> >>Laboratories / Cloud Computing Laboratory
>> >>
>> >>ryanlei@cht.com.tw<
>> https://email.cht.com.tw/owa/redir.aspx?C=-wE1FEC3G0SW
>> >>YpVkiWo8SsDdf3ZqO9AIuAPTzRnFYCUi-z4YljtI_hyVKkNHfn9F1Bn-vUWJnQ4.&URL
>> >>=mail
>> >>to%3aryanlei%40cht.com.tw>
>> >> or
>> >> ryanlei750328@gmail.com
>> >>
>> >>
>> >>
>> >> On Wed, Oct 16, 2013 at 11:23 AM, Chiradeep Vittal <
>> >> Chiradeep.Vittal@citrix.com> wrote:
>> >>
>> >> > Hi folks,
>> >> >
>> >> > I modified cloudmonkey to work off of username and password.
>> >> > Feedback
>> >>and
>> >> > testing required.
>> >> > The code is in the branch  username_password_support
>> >> > http://goo.gl/5xTgo5
>> >> >
>> >> > Thanks
>> >> > --
>> >> > Chiradeep
>> >> >
>> >
>> >--
>> >Prasanna.,
>> >
>> >------------------------
>> >Powered by BigRock.com
>> >
>>
>>


Mime
View raw message