Return-Path: X-Original-To: apmail-incubator-cloudstack-users-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-users-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6A9499525 for ; Wed, 13 Jun 2012 10:23:37 +0000 (UTC) Received: (qmail 10188 invoked by uid 500); 13 Jun 2012 10:23:37 -0000 Delivered-To: apmail-incubator-cloudstack-users-archive@incubator.apache.org Received: (qmail 10164 invoked by uid 500); 13 Jun 2012 10:23:37 -0000 Mailing-List: contact cloudstack-users-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-users@incubator.apache.org Delivered-To: mailing list cloudstack-users@incubator.apache.org Received: (qmail 10153 invoked by uid 99); 13 Jun 2012 10:23:36 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jun 2012 10:23:36 +0000 X-ASF-Spam-Status: No, hits=2.2 required=5.0 tests=HTML_MESSAGE,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of pranav.saxena@citrix.com designates 203.166.19.134 as permitted sender) Received: from [203.166.19.134] (HELO SMTP.CITRIX.COM.AU) (203.166.19.134) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jun 2012 10:23:29 +0000 X-IronPort-AV: E=Sophos;i="4.75,762,1330905600"; d="scan'208,217";a="11715916" Received: from banpmailmx01.citrite.net ([10.103.128.73]) by SYDPIPO01.CITRIX.COM.AU with ESMTP/TLS/RC4-MD5; 13 Jun 2012 10:22:18 +0000 Received: from BANPMAILBOX01.citrite.net ([10.103.128.71]) by BANPMAILMX01.citrite.net ([10.103.128.73]) with mapi; Wed, 13 Jun 2012 15:52:17 +0530 From: Pranav Saxena To: Olga Smola CC: Jessica Wang , "cloudstack-users@incubator.apache.org" , "David Nalley (david@gnsa.us)" , Brian Federle , Sonny Chhen , Will Chan Date: Wed, 13 Jun 2012 15:52:15 +0530 Subject: RE: CloudStack bugs, CS-14896 Thread-Topic: CloudStack bugs, CS-14896 Thread-Index: Ac1JS2wvM/Wfm2QYTtSm3iUcddhK1gAAk8Bg Message-ID: <67EF18FDCA335F489B366120481AB6C5EE3A77B8F7@BANPMAILBOX01.citrite.net> References: <67EF18FDCA335F489B366120481AB6C5EE3A77B767@BANPMAILBOX01.citrite.net> <67EF18FDCA335F489B366120481AB6C5EE3A77B7B4@BANPMAILBOX01.citrite.net> <8EC081586F1D7C41931517E802E947320130423925C6@SJCPMAILBOX01.citrite.net> <67EF18FDCA335F489B366120481AB6C5EE3A77B7D1@BANPMAILBOX01.citrite.net> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: multipart/alternative; boundary="_000_67EF18FDCA335F489B366120481AB6C5EE3A77B8F7BANPMAILBOX01_" MIME-Version: 1.0 --_000_67EF18FDCA335F489B366120481AB6C5EE3A77B8F7BANPMAILBOX01_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Olga , Your patch looks perfect . The code looks similar to the diff file you had= attached yesterday apart from few extra curly braces which are present in = the patch now . Actually I had myself put those extra curly braces at appr= opriate places (which were missing in the diff file)to verify your code cha= nges. I'll ask Brian /Jessica to merge your patch. Thanks & Regards, Pranav From: Olga Smola [mailto:olya.smola@gmail.com] Sent: Wednesday, June 13, 2012 3:31 PM To: Pranav Saxena Cc: Jessica Wang; cloudstack-users@incubator.apache.org; David Nalley (davi= d@gnsa.us); Brian Federle; Sonny Chhen; Will Chan Subject: Re: CloudStack bugs, CS-14896 Hi Pranav, I've just attached git patch to http://bugs.cloudstack.org/browse/CS-14230,= could you please check if it's correct? Thanks, Olga. On Tue, Jun 12, 2012 at 10:33 PM, Pranav Saxena > wrote: Hi Olga, I have reviewed your patch for this bug as well - http://bugs.cloudstack.or= g/browse/CS-14230 . This is what I have to say - 1) The patch looks good but since you had attached the diff file , there wa= s misplacement of the curly braces which was making the situation a little = tedious for us to put your patch at the appropriate places , eventually lea= ding to unnecessary errors . So will it be possible for you to follow the g= it workflow instead of attaching diffs ? This would help us in reviewing yo= ur code more easily and would make the process even more faster. 2) Is it possible for you to make your own private branch ? ( I am not sure= about this ) Otherwise , the patch is perfect and works absolutely fine . Good work !:) Thanks & Regards, Pranav -----Original Message----- From: Jessica Wang Sent: Tuesday, June 12, 2012 11:31 PM To: Pranav Saxena; Olga Smola (olya.smola@gmail.com); cloudstack-users@incubator.apache.org; David Nalley (david@gnsa.us) Cc: Brian Federle; Sonny Chhen; Will Chan Subject: RE: CloudStack bugs, CS-14896 CS-14111 (There is no option to Edit IP ranges of Management Traffic) is in= valid. I've written down my comment and close the bug as "By design". http://bugs.cloudstack.org/browse/CS-14111 -----Original Message----- From: Pranav Saxena Sent: Tuesday, June 12, 2012 9:39 AM To: Olga Smola (olya.smola@gmail.com); cloudst= ack-users@incubator.apache.org; David Nalley (david@gnsa.us) Cc: Jessica Wang; Brian Federle; Sonny Chhen; Will Chan Subject: RE: CloudStack bugs, CS-14896 Hi Olga , I have reviewed the following bugs fixed by you and this is what I have fou= nd - 1) http://bugs.cloudstack.org/browse/CS-14511 - This bug seems to be alread= y fixed in 3.0.3 release . Though your patch of code was perfect. 2) http://bugs.cloudstack.org/browse/CS-13535 - This patch of code works pe= rfect. The bug was reproducible and the spinner never stopped once you crea= ted a child domain with the same name. (Brian you could verify it once more= ). 3) http://bugs.cloudstack.org/browse/CS-12478 - This has also been verified= . The patch looks good according to me . The patches for the other bugs have already been merged or are getting revi= wed. Thanks & Regards, Pranav -----Original Message----- From: David Nalley [mailto:david@gnsa.us] Sent: Tuesday, June 12, 2012 7:25 PM To: Pranav Saxena Cc: Jessica Wang; Brian Federle; Sonny Chhen; Will Chan Subject: Re: CloudStack bugs, CS-14896 Ohhh please do this! If you publicly review all of her existing patches I'll happily propose you= as a committer. (and I'll happily take care of merges too should Jessica/B= rian/Sonny not have issues with this process.) --David On Tue, Jun 12, 2012 at 9:43 AM, Pranav Saxena > wrote: > Hi Olga, > > I am also a UI developer here. I have reviewed most of your diffs which = you have attached with the respective bug tickets and will look at the rema= ining ones very soon .They look good to me. I 'll also ask Jessica /Brian = ( Senior UI developers here ) to merge your patches once they are also sati= sfied with your code changes .In case there are any issues , they'll let yo= u know regarding any further modifications required. > > Thanks & Regards, > Pranav Saxena > > -----Original Message----- > From: Nitin Mehta [mailto:Nitin.Mehta@citrix.com] > Sent: Tuesday, June 12, 2012 5:40 PM > To: Olga Smola; cloudstack-dev@incubator.apache.org; Jessica Wang > Subject: RE: CloudStack bugs, CS-14896 > > This is good work Olga. Were you able to subscribe to the lists I > forwarded you below ? If not, I advise you to do so asap. There is a > way for you to submit your work in form of patches. Refer to the wiki > http://wiki.cloudstack.org/display/dev/Git+workflow+in+the+brave+new+w > orld#Gitworkflowinthebravenewworld-Non-committerworkflow > I am copying you on the dev list to get you going and Jessica is the main= tainer of the UI component so she should be able to help review your work b= ut, you need to follow the procedure in the wiki above to submit your work. > Also once again I request you to subscribe to the Distribution lists belo= w. > > > Thanks, > -Nitin > > From: Olga Smola [mailto:olya.smola@gmail.com] > Sent: Tuesday, June 12, 2012 4:09 PM > To: Nitin Mehta > Subject: Re: CloudStack bugs, CS-14896 > > Hi Nitin, > > could you please help me to ask somebody to review the tickets I've alrea= dy completed? > I've started to work on CloudStack bugs a week ago and I have solutions f= or: > http://bugs.cloudstack.org/browse/CS-14511 > http://bugs.cloudstack.org/browse/CS-13535 > http://bugs.cloudstack.org/browse/CS-14111 > http://bugs.cloudstack.org/browse/CS-14010 (was reviewed yesterday) > http://bugs.cloudstack.org/browse/CS-12478 > http://bugs.cloudstack.org/browse/CS-14230 > http://bugs.cloudstack.org/browse/CS-14896 > and now I'm working on http://bugs.cloudstack.org/browse/CS-4460. > > I can spend some time to work on CloudStack, so if there is actual UI tic= ket, I can work on it. But I don't know to whom should I write to get a fee= dback. > > Best regards, Olga. > On Mon, Jun 11, 2012 at 3:35 PM, Olga Smola >> wrote: > Nitin, > > thanks, I'll write to you if any problems. Have a good day! > > On Mon, Jun 11, 2012 at 1:58 PM, Nitin Mehta >> wrote: > Olga - Please do let me know in case you have a problem catching > somebody to review your code > > From: Olga Smola > [mailto:olya.smola@gmail.com>] > Sent: Monday, June 11, 2012 4:26 PM > To: Nitin Mehta > Subject: Re: CloudStack bugs, CS-14896 > > Hi Nitin, > > thanks a lot. > On Mon, Jun 11, 2012 at 12:45 PM, Nitin Mehta >> wrote: > Olga - This is superb. Since CS has been donated to Apache Server foundat= ion now you can more easily contribute your code (initially as patch) and = become a committer. > I would suggest you to subscribe to the following lists to get going. > > cloudstack-commits-subscribe@incubator.apache.org > mmits-subscribe@incubator.apache.org> > cloudstack-dev-subscribe@incubator.apache.org > bscribe@incubator.apache.org> > cloudstack-users-subscribe@incubator.apache.org > s-subscribe@incubator.apache.org= > > > Just send an email to them to subscribe. > > Refer to this for creating a patch > http://wiki.cloudstack.org/display/dev/Git+workflow+in+the+brave+new+w > orld#Gitworkflowinthebravenewworld-Non-committerworkflow > > > Thanks again, > -Nitin > > From: Olga Smola > [mailto:olya.smola@gmail.com>] > Sent: Monday, June 11, 2012 2:59 PM > To: Nitin Mehta > Subject: CloudStack bugs, CS-14896 > > Hi Nitin, > > excuse me to bother you. My name is Olga, and I'm interested in work on C= loudStack. I'm UI developer and I can help to fix, extend project's UI. I s= aw your post on http://bugs.cloudstack.org/browse/CS-14896 and I think that= my fix should help to you. Also I've fixed several other bugs (http://bugs= .cloudstack.org (http://bugs.cloudstack.org/browse/CS-14511, http://bugs.cl= oudstack.org/browse/CS-13535, http://bugs.cloudstack.org/browse/CS-14111), = but I don't know how can I get the feedback. Maybe you know whom can I writ= e to review my fixes? > > Best regards, Olga Smola. > > > --_000_67EF18FDCA335F489B366120481AB6C5EE3A77B8F7BANPMAILBOX01_--