From issues-return-93449-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Tue Nov 13 09:09:07 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id BC46C18067C for ; Tue, 13 Nov 2018 09:09:06 +0100 (CET) Received: (qmail 82583 invoked by uid 500); 13 Nov 2018 08:09:05 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 82567 invoked by uid 500); 13 Nov 2018 08:09:05 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 82563 invoked by uid 99); 13 Nov 2018 08:09:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Nov 2018 08:09:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 1244DC1D83 for ; Tue, 13 Nov 2018 08:09:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id E0VwoGSFCOnj for ; Tue, 13 Nov 2018 08:09:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 12D33623CC for ; Tue, 13 Nov 2018 08:09:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BEDCEE262F for ; Tue, 13 Nov 2018 08:09:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 123ED25263 for ; Tue, 13 Nov 2018 08:09:01 +0000 (UTC) Date: Tue, 13 Nov 2018 08:09:01 +0000 (UTC) From: "KuiLIU (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (CLOUDSTACK-10365) Inconsistent boolean-related method names MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] KuiLIU resolved CLOUDSTACK-10365. --------------------------------- Resolution: Fixed > Inconsistent boolean-related method names > ----------------------------------------- > > Key: CLOUDSTACK-10365 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10365 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the default.) > Reporter: KuiLIU > Priority: Major > > These boolean-return methods are named as "getXXX". > Other boolean-return methods are named as "isXXX". > Considering there methods will return boolean values, it should be more clear to rename them as "isXXX". > {code:java} > public boolean getEnableRRS() { > return enableRRS; > } > public boolean getEnableRRS() { > return enableRRS; > } > public boolean getShrinkOk() { > return shrinkOk; > } > > public boolean getSourceNat() { > return sourceNat; > } > > public boolean getInternalLb() { > return internalLb; > } > > public boolean getOfferHA() { > return offerHA; > } > > public boolean getVolatileVm() { > return volatileVm; > } > > public boolean getIsUserDefined() { > return isUserDefined; > } > > public boolean getEnablePassword() { > return enablePassword; > } > > public boolean getEnableSshKey() { > return enableSshKey; > } > > public boolean getUuidTranslation() { > return _doUuidTranslation; > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)