From issues-return-93488-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Tue Nov 27 17:22:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 49AD9180670 for ; Tue, 27 Nov 2018 17:22:06 +0100 (CET) Received: (qmail 90386 invoked by uid 500); 27 Nov 2018 16:22:05 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 90377 invoked by uid 500); 27 Nov 2018 16:22:05 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 90374 invoked by uid 99); 27 Nov 2018 16:22:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Nov 2018 16:22:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id F0421180C0B for ; Tue, 27 Nov 2018 16:22:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id c4bFrMePBhCX for ; Tue, 27 Nov 2018 16:22:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id DD88160DF7 for ; Tue, 27 Nov 2018 16:22:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1E9D8E0147 for ; Tue, 27 Nov 2018 16:22:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id D487121094 for ; Tue, 27 Nov 2018 16:22:00 +0000 (UTC) Date: Tue, 27 Nov 2018 16:22:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-3049) marvin-nose plugin causes other nose plugins to fail when not enabled MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-3049?page=3Dcom.atla= ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId= =3D16700651#comment-16700651 ]=20 ASF GitHub Bot commented on CLOUDSTACK-3049: -------------------------------------------- bwsw commented on a change in pull request #3058: CLOUDSTACK-3049: update d= ynamic role for an account URL: https://github.com/apache/cloudstack/pull/3058#discussion_r236739717 =20 =20 ########## File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java ########## @@ -1714,23 +1720,37 @@ public AccountVO updateAccount(UpdateAccountCmd cm= d) { // Check if user performing the action is allowed to modify this a= ccount checkAccess(getCurrentCallingAccount(), _domainMgr.getDomain(accou= nt.getDomainId())); =20 - // check if the given account name is unique in this domain for up= dating - Account duplicateAcccount =3D _accountDao.findActiveAccount(newAcc= ountName, domainId); - if (duplicateAcccount !=3D null && duplicateAcccount.getId() !=3D = account.getId()) { - throw new InvalidParameterValueException( - "There already exists an account with the name:" + new= AccountName + " in the domain:" + domainId + " with existing account id:" += duplicateAcccount.getId()); + if(newAccountName !=3D null) { =20 Review comment: @rafaelweingartner ok. I'll leave as is. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > marvin-nose plugin causes other nose plugins to fail when not enabled > --------------------------------------------------------------------- > > Key: CLOUDSTACK-3049 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-304= 9 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the defa= ult.)=20 > Components: Test Tools > Affects Versions: 4.1.0, 4.2.0 > Reporter: Prasanna Santhanam > Assignee: Prasanna Santhanam > Priority: Major > Fix For: 4.2.0 > > > enabled by default. Running regular nosetests with plugins other than mar= vin > will fail because of this. Failure manifests itself as nose looking for t= he > config file when using the marivn-nose plugin > ~/workspace/cloudstack/incubator-cloudstack(branch:master*) =C2=BB nosete= sts test.py > Traceback (most recent call last): > File "/usr/local/bin/nosetests", line 8, in > load_entry_point('nose=3D=3D1.3.0', 'console_scripts', 'nosetests')() > File "/Library/Python/2.7/site-packages/nose/core.py", line 118, in __i= nit__ > **extra_args) > File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/pyth= on2.7/unittest/main.py", line 94, in __init__ > self.parseArgs(argv) > File "/Library/Python/2.7/site-packages/nose/core.py", line 135, in par= seArgs > self.config.configure(argv, doc=3Dself.usage()) > File "/Library/Python/2.7/site-packages/nose/config.py", line 344, in c= onfigure > self.plugins.configure(options, self) > File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line = 284, in configure > cfg(options, config) > File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line = 99, in __call__ > return self.call(*arg, **kw) > File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line = 167, in simple > result =3D meth(*arg, **kw) > File "/Library/Python/2.7/site-packages/marvin/marvinPlugin.py", line 6= 1, in configure > deploy =3D deployDataCenter.deployDataCenters(options.config)=20 > File "/Library/Python/2.7/site-packages/marvin/deployDataCenter.py", li= ne 32, in __init__ > raise IOError("config file %s not found. please specify a valid confi= g file"%cfgFile) > IOError: config file ./datacenter.cfg not found. please specify a valid c= onfig file -- This message was sent by Atlassian JIRA (v7.6.3#76005)