cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "KuiLIU (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CLOUDSTACK-10360) Inconsistent method name
Date Tue, 13 Nov 2018 08:10:00 GMT

     [ https://issues.apache.org/jira/browse/CLOUDSTACK-10360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

KuiLIU resolved CLOUDSTACK-10360.
---------------------------------
    Resolution: Fixed

> Inconsistent method name
> ------------------------
>
>                 Key: CLOUDSTACK-10360
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10360
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: KuiLIU
>            Priority: Major
>
> The following method is named as "scoped" that seems to whether the variable config is
scoped in _scopedStorages or not.
> Actually, the method tries to find a storage of which scope equals to the scope of config.
> So that, the method name "findStorage" should be more clear than "scoped".
> {code:java}
>     public ScopedConfigStorage scoped(ConfigKey<?> config) {
>         for (ScopedConfigStorage storage : _scopedStorages) {
>             if (storage.getScope() == config.scope()) {
>                 return storage;
>             }
>         }
>         throw new CloudRuntimeException("Unable to find config storage for this scope:
" + config.scope() + " for " + config.key());
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message