cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CLOUDSTACK-3049) marvin-nose plugin causes other nose plugins to fail when not enabled
Date Tue, 27 Nov 2018 15:07:00 GMT


ASF GitHub Bot commented on CLOUDSTACK-3049:

bwsw commented on issue #3058: CLOUDSTACK-3049: update dynamic role for an account
   > Can you instead implement a cleaner approach, say create a new API?
   @rhtyd I considered both alternatives. My arguments for the current implementation:
   1. it adds smoke tests for updateAccount and as you can see before the implementation there
wasn't testing for the method at all.
   2. updateAccount method was strangely implemented, e.g. one has to pass newname mandatory,
this enhancement fixes the behavior as well.
   3. It's natural, I agree with Rafael, otherwise, it's true to implement every `update<Entity><Attribute>`
separately and it will be hell without scoping.
   What do you think?

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> marvin-nose plugin causes other nose plugins to fail when not enabled
> ---------------------------------------------------------------------
>                 Key: CLOUDSTACK-3049
>                 URL:
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Test Tools
>    Affects Versions: 4.1.0, 4.2.0
>            Reporter: Prasanna Santhanam
>            Assignee: Prasanna Santhanam
>            Priority: Major
>             Fix For: 4.2.0
> enabled by default. Running regular nosetests with plugins other than marvin
> will fail because of this. Failure manifests itself as nose looking for the
> config file when using the marivn-nose plugin
> ~/workspace/cloudstack/incubator-cloudstack(branch:master*) ยป nosetests
> Traceback (most recent call last):
>   File "/usr/local/bin/nosetests", line 8, in <module>
>     load_entry_point('nose==1.3.0', 'console_scripts', 'nosetests')()
>   File "/Library/Python/2.7/site-packages/nose/", line 118, in __init__
>     **extra_args)
>   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/",
line 94, in __init__
>     self.parseArgs(argv)
>   File "/Library/Python/2.7/site-packages/nose/", line 135, in parseArgs
>     self.config.configure(argv, doc=self.usage())
>   File "/Library/Python/2.7/site-packages/nose/", line 344, in configure
>     self.plugins.configure(options, self)
>   File "/Library/Python/2.7/site-packages/nose/plugins/", line 284, in configure
>     cfg(options, config)
>   File "/Library/Python/2.7/site-packages/nose/plugins/", line 99, in __call__
>     return*arg, **kw)
>   File "/Library/Python/2.7/site-packages/nose/plugins/", line 167, in simple
>     result = meth(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/marvin/", line 61, in configure
>     deploy = deployDataCenter.deployDataCenters(options.config) 
>   File "/Library/Python/2.7/site-packages/marvin/", line 32, in __init__
>     raise IOError("config file %s not found. please specify a valid config file"%cfgFile)
> IOError: config file ./datacenter.cfg not found. please specify a valid config file

This message was sent by Atlassian JIRA

View raw message