cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-2998) UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, AltGR+Keypad and AltGR+ Numerics
Date Wed, 07 Nov 2018 12:22:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678143#comment-16678143
] 

ASF GitHub Bot commented on CLOUDSTACK-2998:
--------------------------------------------

rafaelweingartner commented on a change in pull request #3000: CLOUDSTACK-2998: Added two
more device name patterns to valid bridge slaves (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000#discussion_r231482349
 
 

 ##########
 File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ##########
 @@ -1291,7 +1292,7 @@ private String matchPifFileInDirectory(final String bridgeName) {
         return "";
     }
 
-    String [] _ifNamePatterns = {
+    static String [] ifNamePatterns = {
 
 Review comment:
   @bwsw, what if we invert the logic?
   
   Let me explain myself. We already have 13! (that is too much; it is indeed a nice magic
number though) patterns to tell which ones are the valid physical interfaces names that we
should look for. However, we can do the opposite. So, we can say that the physical interface
is anything that is not “^vnet*”. Then, if I decide to use a physical interface named
“XYZ”, I will not need to change anything else in the code.
   
   What do you think?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, AltGR+Keypad and AltGR+
Numerics 
> ----------------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-2998
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-2998
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: VNC Proxy
>    Affects Versions: 4.2.0
>         Environment: Build No.#396 (CloudStack-non-OSS-MASTER-396-rhel6.3.tar.gz)
> XenServer6.1 for Host Server, CentOS6.3 for NFS server and CloudStack-Mgr Server, Win7-x86
for Client machine. 
>            Reporter: Minying Bao
>            Priority: Major
>             Fix For: 4.2.0
>
>         Attachments: Build#4.2-241-Exploring Testing_UK Keyboard_issues.xlsx, Exploring
Testing_UK Keyboard_issues.xlsx
>
>
> Steps
> 1. Setup the CloudStack environments with build 4.2#396.
> 2. Bring UK Win-7 x86 VMs.
> 3. Access the VM via Console Proxy from the UK client machines, choose the "UK Keyboard"
for Keyboard Option.
> 4. Make a exploring testing of all the keys with UK keyboard. Just like Ctrl+Keypad keys,
AltGR+Keypad keys or AltGR+ Numeric keys like 1,2,3...
> Expected Result
> All the combination should not return any values.
> Actual Result
> Unexpected output or unexpected operation occurred on some Ctrl+Keypad keys, AltGR+Keypad
keys and AltGR+ Numerics.
> Please refer to the details as attached Excel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message