cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9315) Remove unused classes
Date Mon, 29 Oct 2018 06:39:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16666795#comment-16666795
] 

ASF GitHub Bot commented on CLOUDSTACK-9315:
--------------------------------------------

rhtyd commented on a change in pull request #1448: CLOUDSTACK-9315: Removed unused Classes

URL: https://github.com/apache/cloudstack/pull/1448#discussion_r228812528
 
 

 ##########
 File path: engine/schema/src/main/resources/META-INF/db/schema-41120to41200.sql
 ##########
 @@ -34,4 +34,7 @@ INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, `rule`, `permission`,
 INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, `rule`, `permission`, `sort_order`)
values (UUID(), 3, 'moveNetworkAclItem', 'ALLOW', 302) ON DUPLICATE KEY UPDATE rule=rule;
 INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, `rule`, `permission`, `sort_order`)
values (UUID(), 4, 'moveNetworkAclItem', 'ALLOW', 260) ON DUPLICATE KEY UPDATE rule=rule;
 
-UPDATE `cloud`.`async_job` SET `removed` = now() WHERE `removed` IS NULL;
\ No newline at end of file
+UPDATE `cloud`.`async_job` SET `removed` = now() WHERE `removed` IS NULL;
+
+-- PR#1448 update description of 'execute.in.sequence.network.element.commands' parameter
to reflect an unused command that has been removed. The removed class command is 'UserDataCommand'.
+update configuration set description = 'If set to true, DhcpEntryCommand, SavePasswordCommand,
VmDataCommand will be synchronized on the agent side. If set to false, these commands become
asynchronous. Default value is false.' where name = 'execute.in.sequence.network.element.commands';

 
 Review comment:
   @rafaelweingartner not the comment is to rewrite the update statement as:
   ```
   UPDATE `cloud`.`configuration` SET ...;
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove unused classes
> ---------------------
>
>                 Key: CLOUDSTACK-9315
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9315
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.9.0
>            Reporter: Gabriel Beims Bräscher
>            Assignee: Gabriel Beims Bräscher
>            Priority: Trivial
>
> Remove unused Classes (total of 12 classes and 799 lines to remove):
> - com.cloud.agent.api.CheckStateAnswer
> - com.cloud.agent.api.StartupVMMAgentCommand
> - com.cloud.agent.api.routing.UserDataCommand (remove from description at com.cloud.configuration.Config.ExecuteInSequenceNetworkElementCommands
enum)
> - com.cloud.agent.api.storage.UpgradeDiskCommand
> - com.cloud.agent.api.storage.CreatePrivateTemplateCommand
> - com.cloud.agent.api.storage.DestroyAnswer (Note: "FIXME: Should have an DestroyAnswer"
at com.cloud.storage.resource.StoragePoolResource)
> - com.cloud.agent.api.storage.UpgradeDiskAnswer
> - com.cloud.agent.api.storage.ManageVolumeAvailabilityAnswer
> - com.cloud.agent.api.storage.ManageVolumeAvailabilityCommand
> - com.cloud.exception.UsageServerException
> - com.cloud.info.SecStorageVmLoadInfo
> - com.cloud.serializer.SerializerHelper



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message