From issues-return-93158-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Thu Aug 30 15:20:07 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 74DC3180656 for ; Thu, 30 Aug 2018 15:20:07 +0200 (CEST) Received: (qmail 85719 invoked by uid 500); 30 Aug 2018 13:20:06 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 85675 invoked by uid 500); 30 Aug 2018 13:20:06 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 85666 invoked by uid 99); 30 Aug 2018 13:20:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Aug 2018 13:20:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 1B0231A0813 for ; Thu, 30 Aug 2018 13:20:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id FPVWqt2JeQwR for ; Thu, 30 Aug 2018 13:20:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 7B16F5F3EB for ; Thu, 30 Aug 2018 13:20:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B7A52E0D27 for ; Thu, 30 Aug 2018 13:20:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 76F6126B57 for ; Thu, 30 Aug 2018 13:20:00 +0000 (UTC) Date: Thu, 30 Aug 2018 13:20:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-9473) Storage pool checker is ignored on resize and migrate volume. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-9473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597438#comment-16597438 ] ASF GitHub Bot commented on CLOUDSTACK-9473: -------------------------------------------- DaanHoogland commented on a change in pull request #2829: CLOUDSTACK-9473: storage pool capacity check when volume is resized or migrated URL: https://github.com/apache/cloudstack/pull/2829#discussion_r214026700 ########## File path: server/src/com/cloud/storage/StorageManagerImpl.java ########## @@ -1830,12 +1830,37 @@ public boolean storagePoolHasEnoughSpace(List volumes, StoragePool pool, } } + return checkPoolforSpace(pool, allocatedSizeWithTemplate, totalAskingSize); + } + + @Override + public boolean storagePoolHasEnoughSpaceForResize(StoragePool pool, long currentSize, long newSiz) { + if (!checkUsagedSpace(pool)) { + return false; + } + if (s_logger.isDebugEnabled()) { Review comment: I think as a matter of principle we should alwas add the check. You never no for what reason someone will alter the message. I like using String.format to construct the message, btw, and then pass the single resulting string to the logger ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Storage pool checker is ignored on resize and migrate volume. > ------------------------------------------------------------- > > Key: CLOUDSTACK-9473 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9473 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Components: Storage Controller > Affects Versions: 4.9.0 > Environment: * VMware vCenter 5.5U3/ESXi 5.0 U1 > * ACS 4.9 running on CentOS6.4 > Reporter: Boris Stoyanov > Priority: Major > > *Description:* > Storage pool checker is not being called on resize and migrate volume. This may lead to allocated percentage of storage above 100%. > *Setup:* > 1 VMware cluster with 2 Hosts. > *Executed Steps:* > # Applied the following global settings: > #* storage.overprovisioning.factor = 1 > #* pool.storage.allocated.capacity.disablethreshold = 1 > #* pool.storage.capacity.disablethreshold = 1 > # Restarted management server > # Executed Resize and migrate pool and Observed that Storage pool checker is not performed on resizeVolume and migrateVolume. > *Result:* > Root cause analysis shows storage pool checker is not called when doing migration and resizing. -- This message was sent by Atlassian JIRA (v7.6.3#76005)