From issues-return-92823-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Tue Jun 5 11:40:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DC929180625 for ; Tue, 5 Jun 2018 11:40:03 +0200 (CEST) Received: (qmail 21907 invoked by uid 500); 5 Jun 2018 09:40:02 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 21898 invoked by uid 500); 5 Jun 2018 09:40:02 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 21895 invoked by uid 99); 5 Jun 2018 09:40:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jun 2018 09:40:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 74F041A23B6 for ; Tue, 5 Jun 2018 09:40:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id S1n0KtNBLIfS for ; Tue, 5 Jun 2018 09:40:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 4B4375F19A for ; Tue, 5 Jun 2018 09:40:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CBA25E00A9 for ; Tue, 5 Jun 2018 09:40:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 9137821095 for ; Tue, 5 Jun 2018 09:40:00 +0000 (UTC) Date: Tue, 5 Jun 2018 09:40:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-10382) [ConfigDrive] cloud-get-vm-data-configdrive.in is incorrect MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-10382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501532#comment-16501532 ] ASF GitHub Bot commented on CLOUDSTACK-10382: --------------------------------------------- fmaximus commented on a change in pull request #2688: CLOUDSTACK-10382: Fix cloud-get-vm-data-configdrive.in URL: https://github.com/apache/cloudstack/pull/2688#discussion_r193008730 ########## File path: setup/bindir/cloud-get-vm-data-configdrive.in ########## @@ -21,23 +21,28 @@ mountdir=$(mktemp -d) filepath=$mountdir/cloudstack user_data=$filepath/userdata/user_data.txt -availability_zone=$filepath/metadata/availability_zone.txt Review comment: The original script was only working under bash as well. function is a keyword unknown in `sh`. As specified in the description, the changes require Bash 4. I can also add a version specifically for bash 3, but I suppose with shellshock most people will have upgraded to bash 4 by now. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > [ConfigDrive] cloud-get-vm-data-configdrive.in is incorrect > ----------------------------------------------------------- > > Key: CLOUDSTACK-10382 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10382 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Reporter: Frank Maximus > Assignee: Frank Maximus > Priority: Major > > * As config iso is built using RockRidge/Juliet, dashes aren't replaced anymore. > Script is still referring to the files using underscores. > * BLOCK_DEVICE is still looked up using config i.s.o. config-2 > * -- This message was sent by Atlassian JIRA (v7.6.3#76005)