cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10382) [ConfigDrive] cloud-get-vm-data-configdrive.in is incorrect
Date Tue, 05 Jun 2018 09:40:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501532#comment-16501532
] 

ASF GitHub Bot commented on CLOUDSTACK-10382:
---------------------------------------------

fmaximus commented on a change in pull request #2688: CLOUDSTACK-10382: Fix cloud-get-vm-data-configdrive.in
URL: https://github.com/apache/cloudstack/pull/2688#discussion_r193008730
 
 

 ##########
 File path: setup/bindir/cloud-get-vm-data-configdrive.in
 ##########
 @@ -21,23 +21,28 @@ mountdir=$(mktemp -d)
 filepath=$mountdir/cloudstack
 
 user_data=$filepath/userdata/user_data.txt
-availability_zone=$filepath/metadata/availability_zone.txt
 
 Review comment:
   The original script was only working under bash as well. function is a keyword unknown
in `sh`.
   As specified in the description, the changes require Bash 4.
   I can also add a version specifically for bash 3, but I suppose with shellshock most people
will have upgraded to bash 4 by now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> [ConfigDrive] cloud-get-vm-data-configdrive.in is incorrect
> -----------------------------------------------------------
>
>                 Key: CLOUDSTACK-10382
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10382
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Frank Maximus
>            Assignee: Frank Maximus
>            Priority: Major
>
> * As config iso is built using RockRidge/Juliet, dashes aren't replaced anymore.
> Script is still referring to the files using underscores.
>  * BLOCK_DEVICE is still looked up using config i.s.o. config-2
>  *



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message