cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10381) [ConfigDrive] Password is missing after reset password sequence
Date Mon, 11 Jun 2018 05:14:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507688#comment-16507688
] 

ASF GitHub Bot commented on CLOUDSTACK-10381:
---------------------------------------------

rhtyd commented on a change in pull request #2705: CLOUDSTACK-10381: Fix password reset /
reset ssh key with ConfigDrive
URL: https://github.com/apache/cloudstack/pull/2705#discussion_r194293690
 
 

 ##########
 File path: server/src/com/cloud/network/element/ConfigDriveNetworkElement.java
 ##########
 @@ -223,7 +231,14 @@ public boolean saveSSHKey(final Network network, final NicProfile nic,
final Vir
         if (vm != null && vm.getVirtualMachine().getState().equals(VirtualMachine.State.Running))
{
             throw new CloudRuntimeException("VM should to stopped to reset password");
         }
-        return canHandle(network.getTrafficType());
+
+        final boolean canHandle = canHandle(network.getTrafficType());
+
+        if (canHandle) {
+            storePasswordInVmDetails(vm);
 
 Review comment:
   I may be wrong, but when I tested it I could see different passwords in the isos before
shutdown and post-reset password and startup of the VM @fmaximus. Have you tested this against
a normal config drive enabled network such as a L2 network?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> [ConfigDrive] Password is missing after reset password sequence
> ---------------------------------------------------------------
>
>                 Key: CLOUDSTACK-10381
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10381
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.11.1.0
>            Reporter: Frank Maximus
>            Priority: Blocker
>
> Failing Scenario:
> {quote}*Given* a network offering specifying ConfigDrive as UserData provider
> *And* a network using this offering
> *And* a VM in this network
> *When* I stop the VM
> *and* I reset the password of the VM
> *and* I start the VM
> *Then* I can login with the password returned by the reset password api call
> *And* the password is found on the config drive disk.
> {quote}
> Actual behavior:
> {quote}Password file is missing on config drive disk.
> Password of root on the VM didn't change
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message