cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10365) Inconsistent boolean-related method names
Date Wed, 02 May 2018 07:42:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460633#comment-16460633
] 

ASF GitHub Bot commented on CLOUDSTACK-10365:
---------------------------------------------

DaanHoogland commented on a change in pull request #2602: CLOUDSTACK-10365: Change the "getXXX"
boolean-related method names to…
URL: https://github.com/apache/cloudstack/pull/2602#discussion_r185414457
 
 

 ##########
 File path: api/src/main/java/com/cloud/offering/ServiceOffering.java
 ##########
 @@ -86,7 +86,7 @@
     /**
      * @return Does this service plan support Volatile VM that is, discard VM's root disk
and create a new one on reboot?
      */
-    boolean getVolatileVm();
+    boolean isVolatileVm();
 
 Review comment:
   @BruceKuiLiu I am with 2 all the way, with the exception of the use of these methods in
code generation tools. In this last method I would expect a name like isForVolatileVms() or
the ealier sugested name. Of cause the accessor is named after the field implying that the
field is not properly named either.
   I am +0 on this one. Try to find more reviews.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Inconsistent boolean-related method names
> -----------------------------------------
>
>                 Key: CLOUDSTACK-10365
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10365
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: KuiLIU
>            Priority: Major
>
> These boolean-return methods are named as "getXXX".
> Other boolean-return methods are named as "isXXX".
> Considering there methods will return boolean values, it should be more clear to rename
them as "isXXX".
> {code:java}
>      public boolean getEnableRRS() {
>          return enableRRS;
>      }
>     public boolean getEnableRRS() {
>          return enableRRS;
>      }
>      public boolean getShrinkOk() {
>          return shrinkOk;
>      }
>      
>      public boolean getSourceNat() {
>          return sourceNat;
>      }
>      
>      public boolean getInternalLb() {
>          return internalLb;
>      }
>      
>      public boolean getOfferHA() {
>          return offerHA;
>      }
>      
>       public boolean getVolatileVm() {
>          return volatileVm;
>      }
>      
>      public boolean getIsUserDefined() {
>          return isUserDefined;
>      }
>      
>       public boolean getEnablePassword() {
>          return enablePassword;
>      }
>      
>      public boolean getEnableSshKey() {
>          return enableSshKey;
>      }
>      
>      public boolean getUuidTranslation() {
>          return _doUuidTranslation;
>      }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message