cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10362) Inconsistent method names
Date Fri, 04 May 2018 02:52:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463310#comment-16463310
] 

ASF GitHub Bot commented on CLOUDSTACK-10362:
---------------------------------------------

blueorangutan commented on issue #2600: CLOUDSTACK-10362: Change the "getXXX" method names
to "isXXX".
URL: https://github.com/apache/cloudstack/pull/2600#issuecomment-386494010
 
 
   <b>Trillian test result (tid-2589)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 43342 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2600-t2589-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 63 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 393.66 | test_internal_lb.py
   test_01_secured_vm_migration | `Error` | 43.55 | test_vm_life_cycle.py
   test_02_not_secured_vm_migration | `Error` | 42.51 | test_vm_life_cycle.py
   test_03_secured_to_nonsecured_vm_migration | `Error` | 42.51 | test_vm_life_cycle.py
   test_04_nonsecured_to_secured_vm_migration | `Error` | 42.49 | test_vm_life_cycle.py
   test_11_migrate_volume_and_change_offering | `Error` | 129.09 | test_volumes.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 3.48 | test_hostha_kvm.py
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Inconsistent method names
> -------------------------
>
>                 Key: CLOUDSTACK-10362
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10362
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: KuiLIU
>            Priority: Major
>
> Some Boolean-return methods are named "getXXX",
> but other Boolean-return methods are named "isXXX", such as the following two methods.
> They will return boolean values, rename them as "isXXX" should be more clear than "getXXX".
> api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
> {code:java}
>      public Boolean getForVirtualNetwork() {
>          return forVirtualNetwork;
>      }
> {code}
> api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
> {code:java}
>     public Boolean isForVirtualNetwork() {
>         return forVirtualNetwork;
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message