cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CLOUDSTACK-10232) SystemVMs and VR to run as HVM on XenServer
Date Thu, 03 May 2018 08:17:00 GMT


ASF GitHub Bot commented on CLOUDSTACK-10232:

rhtyd commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run
as HVM on XenServer

 File path: systemvm/debian/opt/cloud/bin/setup/cloud-early-config
 @@ -64,10 +71,17 @@ config_guest() {
 get_boot_params() {
   case $HYPERVISOR in
-     xen-domU|xen-hvm)
+     xen-pv)
           cat /proc/cmdline > $CMDLINE
           sed -i "s/%/ /g" $CMDLINE
+     xen-hvm)
+          if [ ! -f /usr/sbin/xenstore-read ]; then
+            log_it "ERROR: xentools not installed, cannot found xenstore-read" &&
exit 5
+          fi
+          /usr/sbin/xenstore-read vm-data/cloudstack/init > /var/cache/cloud/cmdline
 Review comment:
   @khos2ow I think you're missing a big point and I'm wondering how you're testing your changes.
This script runs inside CloudStack's systemvmtemplate that is based on Debian 9 for 4.11+.
For the change in 4.11 branch, the test/changes must be performed on Debian9 based guest vm
only. In our built template, the path to `xenstore-read` is at `/usr/bin`. Regarding the `virt-what`
comment, again the version of virt-what is specific to the Debian 9 based systemvmtemplate
that would return xen-hvm in my tests across XenServer 6.5-7.x versions. I'll therefore keep
my changes that are tested against 4.11 systemvmtemplate. Temporarily hosted here are latest
4.11 templates if you want to try them:

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> SystemVMs and VR to run as HVM on XenServer
> -------------------------------------------
>                 Key: CLOUDSTACK-10232
>                 URL:
>             Project: CloudStack
>          Issue Type: New Feature
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: SystemVM, Virtual Router, XenServer
>    Affects Versions:,
>            Reporter: Pierre-Luc Dion
>            Priority: Major
> Following the recent Meltdown-Spectre security risk,one of the mitigation,as of Jan 2018,
for XenServer Hypervisor is to run Virtual-Machine in HVM mode.
> Currently SystemVMs and Virtual-Routers run as PV on XenServer and the eth0 is configured
using {{/etc/init.d/cloud-early-config}} using grub params from {{/proc/cmdline}}. When VM
run as HVM, it is not possible to push initial boot instruction via pygrub.
> Quick tests has been done using xenstore and it look like it would be possible to send
same initial boot instruction has pygrub but using xenstore for HVM instances.

This message was sent by Atlassian JIRA

View raw message