From issues-return-92112-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Tue Apr 24 11:44:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0E9BD180671 for ; Tue, 24 Apr 2018 11:44:02 +0200 (CEST) Received: (qmail 86931 invoked by uid 500); 24 Apr 2018 09:44:02 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 86918 invoked by uid 500); 24 Apr 2018 09:44:02 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 86913 invoked by uid 99); 24 Apr 2018 09:44:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Apr 2018 09:44:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id A4DA8180156 for ; Tue, 24 Apr 2018 09:44:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id AnMuA1ZuBjkq for ; Tue, 24 Apr 2018 09:44:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C6E015FB5F for ; Tue, 24 Apr 2018 09:44:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5B763E0231 for ; Tue, 24 Apr 2018 09:44:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1124821208 for ; Tue, 24 Apr 2018 09:44:00 +0000 (UTC) Date: Tue, 24 Apr 2018 09:44:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-10364) Inconsiste "setXXX" method names. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-10364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449540#comment-16449540 ] ASF GitHub Bot commented on CLOUDSTACK-10364: --------------------------------------------- BruceKuiLiu opened a new pull request #2601: CLOUDSTACK-10364: Change the "setXXX" method names to "getXXX". URL: https://github.com/apache/cloudstack/pull/2601 The two methods are named as "setXXX", actually, they are not setter but getter. Thus, they should be renamed as "getXXX". ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Inconsiste "setXXX" method names. > --------------------------------- > > Key: CLOUDSTACK-10364 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10364 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the default.) > Reporter: KuiLIU > Priority: Major > > The following two methods are named as "setXXX", > actually, they are not setter but getter. > Thus, they should be renamed as "getXXX". > {code:java} > private String setVnetBrName(String pifName, String vnetId) { > return "br" + pifName + "-" + vnetId; > } > private String setVxnetBrName(String pifName, String vnetId) { > return "brvx-" + vnetId; > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)