From issues-return-92044-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Thu Apr 19 21:01:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id ACC9918076D for ; Thu, 19 Apr 2018 21:01:04 +0200 (CEST) Received: (qmail 36054 invoked by uid 500); 19 Apr 2018 19:01:03 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 36045 invoked by uid 500); 19 Apr 2018 19:01:03 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 36042 invoked by uid 99); 19 Apr 2018 19:01:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Apr 2018 19:01:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 4CAACC00DA for ; Thu, 19 Apr 2018 19:01:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 76dCEQiSfoC0 for ; Thu, 19 Apr 2018 19:01:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 4C9145F56B for ; Thu, 19 Apr 2018 19:01:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6E5D4E0C9B for ; Thu, 19 Apr 2018 19:01:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1B8F72120A for ; Thu, 19 Apr 2018 19:01:00 +0000 (UTC) Date: Thu, 19 Apr 2018 19:01:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-10357) Log messages that do not match with their method function MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-10357?page=3Dcom.atl= assian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId= =3D16444630#comment-16444630 ]=20 ASF GitHub Bot commented on CLOUDSTACK-10357: --------------------------------------------- rhtyd commented on a change in pull request #2580: CLOUDSTACK-10357 Improve= log messages that do not match with their method function URL: https://github.com/apache/cloudstack/pull/2580#discussion_r182851822 =20 =20 ########## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/= storage/KVMStorageProcessor.java ########## @@ -1309,10 +1309,10 @@ public Answer dettachVolume(final DettachCommand c= md) { =20 return new DettachAnswer(disk); } catch (final LibvirtException e) { - s_logger.debug("Failed to attach volume: " + vol.getPath() + "= , due to ", e); + s_logger.debug("Failed to dettach volume: " + vol.getPath() + = ", due to ", e); =20 Review comment: The correct spelling is `detach`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Log messages that do not match with their method function > --------------------------------------------------------- > > Key: CLOUDSTACK-10357 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-103= 57 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the defa= ult.)=20 > Reporter: Zhenhao Li > Priority: Minor > Labels: easyfix > > There are some possible copy and paste errors in the log messages (The lo= gging statement was copied from an old place to a new place, but the messag= e wasn't changed to adapt to the function of new place) which may cause con= fusion when operators are reading the log messages.=C2=A0 > =C2=A0 > Here is a list of the related logging statements: > *1. s_logger.debug("Failed to attach volume: " + vol.getPath() + ", due t= o ", e);* > =C2=A0 =C2=A0 =C2=A0 *Callsites:* > * _com.cloud.hypervisor.kvm.storage.KVMStorageProcessor.*attachVolume()*= ,_ > * com.cloud.hypervisor.kvm.storage.KVMStorageProcessor.*dettachVolume()*= =C2=A0 > =C2=A0 > *2. s_logger.debug("Failed to retrive the default label for management tr= affic:" + "zone: " ...* > =C2=A0 =C2=A0 =C2=A0 *Callsites:* > * com.cloud.network.NetworkModelImpl.*getDefaultManagementTrafficLabel()= *, > * com.cloud.network.NetworkModelImpl.*getDefaultGuestTrafficLabel()* > =C2=A0 > *3. s_logger.error("Can not find the groupid " + groupId + " for scaling = up");* > =C2=A0 =C2=A0 =C2=A0 *Callsites:* > * _com.cloud.network.as.AutoScaleManagerImpl.*doScaleDown()*,_ > * com.cloud.network.as.AutoScaleManagerImpl.*doScaleUp()* > =C2=A0 > *4. s_logger.warn("No DNS entry found during configuration of NfsSecondar= yStorage");* > =C2=A0 =C2=A0 =C2=A0 *Callsites:* > * _com.cloud.agent.resource.consoleproxy.*ConsoleProxyResource*.configur= e(),_ > * org.apache.cloudstack.storage.resource.*NfsSecondaryStorageResource*.c= onfigure() > =C2=A0 > *5. s_logger.trace("vCenter API trace - searchDatastore() done");* > =C2=A0 =C2=A0 =C2=A0 *Callsites:* > * com.cloud.hypervisor.vmware.mo.HostDatastoreBrowserMO.*searchDatastore= SubFolders()*, > * com.cloud.hypervisor.vmware.mo.HostDatastoreBrowserMO.*searchDatastore= ()* > =C2=A0 > *6. s_logger.trace("vCenter API trace - detachIso() done(failed)");* > =C2=A0 =C2=A0 =C2=A0 *Callsites:* > * com.cloud.hypervisor.vmware.mo.VirtualMachineMO.*detachIso()*, > * com.cloud.hypervisor.vmware.mo.VirtualMachineMO.*attachIso()* > =C2=A0 > *7. s_logger.warn(String.format("unable to add baremetal RCT[%s]" ...* > =C2=A0 =C2=A0 =C2=A0 *Callsites:* > * org.apache.cloudstack.api.*AddBaremetalRctCmd*.execute(), > * org.apache.cloudstack.api.*DeleteBaremetalRctCmd*.execute(), > =C2=A0 > *8. s_logger.debug("POST request to " + agentUri.toString() + " with cont= ents " + logMessage);* > =C2=A0 =C2=A0 =C2=A0 *Callsites:* > * com.cloud.network.resource.NetScalerControlCenterResource.*postHttpReq= uest()*, > * com.cloud.network.resource.NetScalerControlCenterResource.*getHttpRequ= est()*, > =C2=A0 > *9. LOG.error("Failed to remove group due to:", e);* > =C2=A0 =C2=A0 =C2=A0 *Callsites:* > * _org.apache.cloudstack.cloudian.client.CloudianClient.*removeGroup()*,= _ > * org.apache.cloudstack.cloudian.client.CloudianClient.*updateGroup()* > =C2=A0 > *10. s_logger.warn("Unable to initialize inaccurate clock", e);* > =C2=A0 =C2=A0 =C2=A0 *Callsites:* > * com.cloud.utils.time.*InaccurateClock*.InaccurateClock(), > * com.cloud.network.resource.*NuageVspResource*.stop() > =C2=A0 > *11. s_logger.error("listVmDetails:Exception:" + e.getMessage());* > =C2=A0 =C2=A0 =C2=A0 *Callsites:* > * _com.cloud.vm.dao.UserVmDaoImpl.*listVmDetails()*,_ > * com.cloud.vm.dao.UserVmDaoImpl.*listPodIdsHavingVmsforAccount()* > =C2=A0 > *12. s_logger.error("Unable to dedicate host due to " + e.getMessage(), e= );* > =C2=A0 =C2=A0 =C2=A0 *Callsites:* > * org.apache.cloudstack.dedicated.DedicatedResourceManagerImpl.*dedicate= Host()*, > * org.apache.cloudstack.dedicated.DedicatedResourceManagerImpl.*dedicate= Cluster()* > =C2=A0 > =C2=A0 > =C2=A0 > =C2=A0 > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)