From issues-return-91956-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Wed Apr 18 13:04:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 83E2718064E for ; Wed, 18 Apr 2018 13:04:05 +0200 (CEST) Received: (qmail 64258 invoked by uid 500); 18 Apr 2018 11:04:04 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 64247 invoked by uid 500); 18 Apr 2018 11:04:04 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 64243 invoked by uid 99); 18 Apr 2018 11:04:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Apr 2018 11:04:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A303BC79D3 for ; Wed, 18 Apr 2018 11:04:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 4Vem2HcnhXNc for ; Wed, 18 Apr 2018 11:04:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 5D9FF5FDA5 for ; Wed, 18 Apr 2018 11:04:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 10A9EE030E for ; Wed, 18 Apr 2018 11:04:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id A4C67241D2 for ; Wed, 18 Apr 2018 11:04:00 +0000 (UTC) Date: Wed, 18 Apr 2018 11:04:00 +0000 (UTC) From: =?utf-8?Q?Rafael_Weing=C3=A4rtner_=28JIRA=29?= To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (CLOUDSTACK-10356) Fix Some Potential NPE MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-10356?page=3Dcom.at= lassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael Weing=C3=A4rtner reassigned CLOUDSTACK-10356: ----------------------------------------------- Assignee: (was: Rafael Weing=C3=A4rtner) > Fix Some Potential NPE=20 > ----------------------- > > Key: CLOUDSTACK-10356 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-103= 56 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the defa= ult.)=20 > Affects Versions: 4.12.0.0 > Reporter: lujie > Priority: Major > Attachments: CLOUDSTACK-10356_1.patch > > > We have developed a static analysis tool=C2=A0[NPEDetector|https://github= .com/lujiefsi/NPEDetector]=C2=A0to find some potential NPE. Our analysis sh= ows that some callees may return null in corner case(e.g. node crash , IO e= xception), some of their callers have=C2=A0 _!=3Dnull_=C2=A0check but some = do not have. In this issue we post a patch which can add=C2=A0 !=3Dnull=C2= =A0 based on existed !=3Dnull=C2=A0 check. For example: > Callee=C2=A0GlobalLoadBalancingRulesServiceImpl#lookupGslbServiceProvider= : > {code:java} > protected GslbServiceProvider lookupGslbServiceProvider() { > return _gslbProviders.size() =3D=3D 0 ? null : _gslbProviders.get(0);= // may return null; > } > {code} > Caller=C2=A0GlobalLoadBalancingRulesServiceImpl#checkGslbServiceEnabledIn= Zone have _!=3Dnull_: > {code:java} > private boolean checkGslbServiceEnabledInZone(long zoneId, long physicalN= etworkId) { > GslbServiceProvider gslbProvider =3D lookupGslbServiceProvider(); > if (gslbProvider =3D=3D null) { > throw new CloudRuntimeException("No GSLB provider is available"); > } > return gslbProvider.isServiceEnabledInZone(zoneId, physicalNetworkId); > } > {code} > but another GlobalLoadBalancingRulesServiceImpl#applyGlobalLoadBalancerRu= leConfig does not have !=3Dnull check: > {code:java} > GslbServiceProvider gslbProvider =3D lookupGslbServiceProvider(); > siteLb.setGslbProviderPublicIp(gslbProvider.getZoneGslbProviderPublicIp(d= ataCenterId,physicalNetworkId)); > .........{code} > So we will add below code in non-(!=3Dnull) caller GlobalLoadBalancingRul= esServiceImpl#applyGlobalLoadBalancerRuleConfig > {code:java} > if (gslbProvider =3D=3D null) { > throw new CloudRuntimeException("No GSLB provider is available"); > } > {code} > But due to we are not very=C2=A0=C2=A0familiar with CLOUDSTACK,=C2=A0hope= some=C2=A0expert can review it. > Thanks!!!! -- This message was sent by Atlassian JIRA (v7.6.3#76005)