cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10362) Inconsistent method names
Date Thu, 26 Apr 2018 13:22:13 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454057#comment-16454057
] 

ASF GitHub Bot commented on CLOUDSTACK-10362:
---------------------------------------------

rafaelweingartner commented on issue #2599: CLOUDSTACK-10362, CLOUDSTACK-10363, CLOUDSTACK-10364,
CLOUDSTACK-10365 Change method names.
URL: https://github.com/apache/cloudstack/pull/2599#issuecomment-384638539
 
 
   @BruceKuiLiu even though everything seems to be ok here, I actually likes the three separated
PRs. It reduced the scope for reviewers.
   
   If you are going to proceed only with this one, can you please close the others? The choice
is yours.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Inconsistent method names
> -------------------------
>
>                 Key: CLOUDSTACK-10362
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10362
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: KuiLIU
>            Priority: Major
>
> Some Boolean-return methods are named "getXXX",
> but other Boolean-return methods are named "isXXX", such as the following two methods.
> They will return boolean values, rename them as "isXXX" should be more clear than "getXXX".
> api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java
> {code:java}
>      public Boolean getForVirtualNetwork() {
>          return forVirtualNetwork;
>      }
> {code}
> api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java
> {code:java}
>     public Boolean isForVirtualNetwork() {
>         return forVirtualNetwork;
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message