cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10357) Log messages that do not match with their method function
Date Wed, 18 Apr 2018 19:33:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443073#comment-16443073
] 

ASF GitHub Bot commented on CLOUDSTACK-10357:
---------------------------------------------

lzh3636 opened a new pull request #2580: CLOUDSTACK-10357 Improve log messages that do not
match with their method function
URL: https://github.com/apache/cloudstack/pull/2580
 
 
   ## Description
   <!--- Describe your changes in detail -->
   There are some possible copy and paste errors in the log messages (The logging statement
was copied from an old place to a new place, but the message wasn't changed to adapt to the
function of new place).
   
   Here's a list of this kind of problems I found, which contains the original place that
the logging statement possibly be copied from, and the new place that the log be copied to
(the log message is not suitable for the new place and should be changed):
   https://issues.apache.org/jira/browse/CLOUDSTACK-10357
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that
apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   
   ## Checklist:
   <!--- Go over all the following points, and put an `x` in all the boxes that apply.
-->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help!
-->
   - [x] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
document.
   - [x] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   Testing
   - [ ] I have added tests to cover my changes.
   - [ ] All relevant new and existing integration tests have passed.
   - [ ] A full integration testsuite with all test that can run on my environment has passed.
   
   <!-- The following will kick a packaging job, remove if as applicable -->
   @blueorangutan package
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Log messages that do not match with their method function
> ---------------------------------------------------------
>
>                 Key: CLOUDSTACK-10357
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10357
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Zhenhao Li
>            Priority: Minor
>              Labels: easyfix
>
> There are some possible copy and paste errors in the log messages (The logging statement
was copied from an old place to a new place, but the message wasn't changed to adapt to the
function of new place) which may cause confusion when operators are reading the log messages. 
>  
> Here is a list of the related logging statements:
> *1. s_logger.debug("Failed to attach volume: " + vol.getPath() + ", due to ", e);*
>       *Callsites:*
>  * _com.cloud.hypervisor.kvm.storage.KVMStorageProcessor.*attachVolume()*,_
>  * com.cloud.hypervisor.kvm.storage.KVMStorageProcessor.*dettachVolume()* 
>  
> *2. s_logger.debug("Failed to retrive the default label for management traffic:" + "zone:
" ...*
>       *Callsites:*
>  * com.cloud.network.NetworkModelImpl.*getDefaultManagementTrafficLabel()*,
>  * com.cloud.network.NetworkModelImpl.*getDefaultGuestTrafficLabel()*
>  
> *3. s_logger.error("Can not find the groupid " + groupId + " for scaling up");*
>       *Callsites:*
>  * _com.cloud.network.as.AutoScaleManagerImpl.*doScaleDown()*,_
>  * com.cloud.network.as.AutoScaleManagerImpl.*doScaleUp()*
>  
> *4. s_logger.warn("No DNS entry found during configuration of NfsSecondaryStorage");*
>       *Callsites:*
>  * _com.cloud.agent.resource.consoleproxy.*ConsoleProxyResource*.configure(),_
>  * org.apache.cloudstack.storage.resource.*NfsSecondaryStorageResource*.configure()
>  
> *5. s_logger.trace("vCenter API trace - searchDatastore() done");*
>       *Callsites:*
>  * com.cloud.hypervisor.vmware.mo.HostDatastoreBrowserMO.*searchDatastoreSubFolders()*,
>  * com.cloud.hypervisor.vmware.mo.HostDatastoreBrowserMO.*searchDatastore()*
>  
> *6. s_logger.trace("vCenter API trace - detachIso() done(failed)");*
>       *Callsites:*
>  * com.cloud.hypervisor.vmware.mo.VirtualMachineMO.*detachIso()*,
>  * com.cloud.hypervisor.vmware.mo.VirtualMachineMO.*attachIso()*
>  
> *7. s_logger.warn(String.format("unable to add baremetal RCT[%s]" ...*
>       *Callsites:*
>  * org.apache.cloudstack.api.*AddBaremetalRctCmd*.execute(),
>  * org.apache.cloudstack.api.*DeleteBaremetalRctCmd*.execute(),
>  
> *8. s_logger.debug("POST request to " + agentUri.toString() + " with contents " + logMessage);*
>       *Callsites:*
>  * com.cloud.network.resource.NetScalerControlCenterResource.*postHttpRequest()*,
>  * com.cloud.network.resource.NetScalerControlCenterResource.*getHttpRequest()*,
>  
> *9. LOG.error("Failed to remove group due to:", e);*
>       *Callsites:*
>  * _org.apache.cloudstack.cloudian.client.CloudianClient.*removeGroup()*,_
>  * org.apache.cloudstack.cloudian.client.CloudianClient.*updateGroup()*
>  
> *10. s_logger.warn("Unable to initialize inaccurate clock", e);*
>       *Callsites:*
>  * com.cloud.utils.time.*InaccurateClock*.InaccurateClock(),
>  * com.cloud.network.resource.*NuageVspResource*.stop()
>  
> *11. s_logger.error("listVmDetails:Exception:" + e.getMessage());*
>       *Callsites:*
>  * _com.cloud.vm.dao.UserVmDaoImpl.*listVmDetails()*,_
>  * com.cloud.vm.dao.UserVmDaoImpl.*listPodIdsHavingVmsforAccount()*
>  
> *12. s_logger.error("Unable to dedicate host due to " + e.getMessage(), e);*
>       *Callsites:*
>  * org.apache.cloudstack.dedicated.DedicatedResourceManagerImpl.*dedicateHost()*,
>  * org.apache.cloudstack.dedicated.DedicatedResourceManagerImpl.*dedicateCluster()*
>  
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message