cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10223) Snapshots are not getting deleted when domain is deleted
Date Sat, 28 Apr 2018 11:42:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457554#comment-16457554
] 

ASF GitHub Bot commented on CLOUDSTACK-10223:
---------------------------------------------

rafaelweingartner commented on a change in pull request #2399: CLOUDSTACK-10223 delete snapshots
when deleting domain
URL: https://github.com/apache/cloudstack/pull/2399#discussion_r184850779
 
 

 ##########
 File path: server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java
 ##########
 @@ -715,7 +715,7 @@ public String getSecondaryStorageURL(SnapshotVO snapshot) {
     @Override
     public boolean deleteSnapshotDirsForAccount(long accountId) {
 
-        List<VolumeVO> volumes = _volsDao.findByAccount(accountId);
+        List<VolumeVO> volumes = _volsDao.findIncludingRemovedByAccount(accountId);
 
 Review comment:
   I just checked, and indeed snapshots have an entry in the `volumes` table. On the other
hand, I could not find entries for volumes, but this does not affect the PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Snapshots are not getting deleted when domain is deleted
> --------------------------------------------------------
>
>                 Key: CLOUDSTACK-10223
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10223
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Sowjanya_Patha
>            Priority: Minor
>
> After domain deletion, snapshot taken by the domain remains undeleted.
> Steps to reproduce:
> -----------------------------------------------
> 1. Create a test domain
> 2. Create test account with admin privileges.
> 3. Login as "test" acoount.
> 4. Create 3 instances - few having root disk and rest with root and data disks both.
> 5. For 2 instances take snapshots of root and data disks
> 6. Expunge above instances from ACP UI.
> 7. Make sure that those vm's should not be shown in ACP UI.
> 8. Login as root user again
> 9. Delete the test account
> 10. Delete the test domain
> Snapshots taken for root volume in step 5 are not deleted.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message