cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9114) restartnetwork with cleanup should not update/restart both routers at once
Date Mon, 30 Apr 2018 10:00:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458439#comment-16458439
] 

ASF GitHub Bot commented on CLOUDSTACK-9114:
--------------------------------------------

rafaelweingartner commented on a change in pull request #2508: CLOUDSTACK-9114: Reduce VR
downtime during network restart
URL: https://github.com/apache/cloudstack/pull/2508#discussion_r184948864
 
 

 ##########
 File path: server/src/com/cloud/network/vpc/VpcManagerImpl.java
 ##########
 @@ -1508,19 +1519,33 @@ public boolean restartVpc(final long vpcId, final boolean cleanUp,
final boolean
 
                 // Change the VPC in order to get it updated after the end of
                 // the restart procedure.
-                _vpcDao.update(vpc.getId(), entity);
+                if (_vpcDao.update(vpc.getId(), entity)) {
+                    vpc = entity;
+                }
 
                 // If the offering and redundant column are changing, force the
                 // clean up.
                 forceCleanup = true;
             }
 
             if (forceCleanup) {
 
 Review comment:
   Yes it is, if you consider only the body of the IF, but the method is already quite big.
 The more we extract, the more unit tests we enable. Moreover, it becomes easier to read the
code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> restartnetwork with cleanup should not update/restart both routers at once
> --------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9114
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9114
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Wei Zhou
>            Assignee: Wei Zhou
>            Priority: Major
>
> for now, restartnetwork with cleanup will stop both RVRs at first, then start two  new
RVRs.
> to reduce the downtime of network, we'd better restart the RVRs one by one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message