From issues-return-91237-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Wed Mar 21 22:08:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6323018067E for ; Wed, 21 Mar 2018 22:08:04 +0100 (CET) Received: (qmail 71338 invoked by uid 500); 21 Mar 2018 21:08:03 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 71329 invoked by uid 500); 21 Mar 2018 21:08:03 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 71326 invoked by uid 99); 21 Mar 2018 21:08:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Mar 2018 21:08:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id EAC60C0529 for ; Wed, 21 Mar 2018 21:08:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id fzbCSferBbo9 for ; Wed, 21 Mar 2018 21:08:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 08B435F17B for ; Wed, 21 Mar 2018 21:08:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 771A8E0253 for ; Wed, 21 Mar 2018 21:08:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3A8A4214C1 for ; Wed, 21 Mar 2018 21:08:00 +0000 (UTC) Date: Wed, 21 Mar 2018 21:08:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-10332) Users are not able to change/edit the protocol of an ACL rule MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-10332?page=3Dcom.atl= assian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId= =3D16408583#comment-16408583 ]=20 ASF GitHub Bot commented on CLOUDSTACK-10332: --------------------------------------------- blueorangutan commented on issue #2496: [CLOUDSTACK-10332] Users are not ab= le to change/edit the protocol of an ACL rule=20 URL: https://github.com/apache/cloudstack/pull/2496#issuecomment-375095784 =20 =20 Trillian test result (tid-2397) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43766 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/= trillian/pr2496-t2397-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_certauthority_roo= t.py Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.p= y Intermitten failure detected: /marvin/tests/smoke/test_templates.py Intermitten failure detected: /marvin/tests/smoke/test_usage.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.= py Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 62 look OK, 5 have error(s) Only failed tests results shown below: =20 =20 Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_extract_template | `Failure` | 128.32 | test_templates.py ContextSuite context=3DTestISOUsage>:setup | `Error` | 0.00 | test_usage= .py test_06_download_detached_volume | `Failure` | 137.75 | test_volumes.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 313.72 | test_= vpc_redundant.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 2.83 | test_h= ostha_kvm.py =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Users are not able to change/edit the protocol of an ACL rule=20 > -------------------------------------------------------------- > > Key: CLOUDSTACK-10332 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-103= 32 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the defa= ult.)=20 > Reporter: Rafael Weing=C3=A4rtner > Assignee: Rafael Weing=C3=A4rtner > Priority: Major > Fix For: 4.12 > > > Users should be able to edit an ACL rule completely. Therefore, they must= be able to change the protocol type and others configs of an ACL rules. > Right now users are not able to execute the following.=20 > * Create an ACL for ICMP > * Click on edit and change the protocol to TCP > * An error will happen when saving the rule. > Users should be able to execute the protocol changes without problem. > In addition, it is not just the protocol that users are not able to chang= e. For instance, after defining ports, or reason/description for the rule, = users are not able to set those values back to null. The same happens for I= CMP code and type. > We will introduce a new parameter called "partialUpdate", which will have= its default value as true to maintain backward compatibility. When this pa= rameter is set to false, we will consider only the parameters sent, and not= the parameters we already have in the database to change and validate the = ACL rule data. This allows us to update parameters already set back to null= , and to completely change an ACL rule. -- This message was sent by Atlassian JIRA (v7.6.3#76005)