From issues-return-90973-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Thu Mar 15 11:23:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id EA7A8180649 for ; Thu, 15 Mar 2018 11:23:04 +0100 (CET) Received: (qmail 89465 invoked by uid 500); 15 Mar 2018 10:23:03 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 89456 invoked by uid 500); 15 Mar 2018 10:23:03 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 89453 invoked by uid 99); 15 Mar 2018 10:23:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Mar 2018 10:23:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 7E00818032D for ; Thu, 15 Mar 2018 10:23:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 4U2i7HD5asmU for ; Thu, 15 Mar 2018 10:23:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 697145F175 for ; Thu, 15 Mar 2018 10:23:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 91FAEE0142 for ; Thu, 15 Mar 2018 10:23:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0F2D52148F for ; Thu, 15 Mar 2018 10:23:00 +0000 (UTC) Date: Thu, 15 Mar 2018 10:23:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-10323) Change disk offering when volume is migrated to different type of storage pool. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-10323?page=3Dcom.atl= assian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId= =3D16400170#comment-16400170 ]=20 ASF GitHub Bot commented on CLOUDSTACK-10323: --------------------------------------------- rafaelweingartner commented on issue #2486: [CLOUDSTACK-10323] Allow changi= ng disk offering during volume migration=20 URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-373328490 =20 =20 Thanks! You can open a PR against my branch, then I can merge it here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Change disk offering when volume is migrated to different type of storage= pool. > -------------------------------------------------------------------------= ------ > > Key: CLOUDSTACK-10323 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-103= 23 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the defa= ult.)=20 > Affects Versions: 4.12 > Reporter: Rafael Weing=C3=A4rtner > Assignee: Rafael Weing=C3=A4rtner > Priority: Major > > This is a continuation of work developed on PR #2425 (CLOUDSTACK-10240), = which provided root admins an override mechanism to move volumes between st= orage systems types (local/shared) even when the disk offering would not al= low such operation. To complete the work, we will now provide a way for adm= inistrators to enter a new disk offering that can reflect the new placement= of the volume. We will add an extra parameter to allow the root admin info= rm a new disk offering for the volume. Therefore, when the volume is being = migrated, it will be possible to replace the disk offering to reflect the n= ew placement of the volume. > The API method will have the following parameters:=20 > * storageid (required) > * volumeid (required) > * livemigrate(optional) > * newdiskofferingid (optional) =E2=80=93 this is the new parameter > The expected behavior is the following:=20 > * If =E2=80=9Cnewdiskofferingid=E2=80=9D is not provided the current beha= vior is maintained. Override mechanism will also keep working as we have se= en so far.=20 > * If the =E2=80=9Cnewdiskofferingid=E2=80=9D is provided by the admin, we= will execute the following checks > ** new disk offering mode (local/shared) must match the target storage mo= de. If it does not match, an exception will be thrown and the operator will= receive a message indicating the problem. > ** we will check if the new disk offering tags match the target storage t= ags. If it does not match, an exception will be thrown and the operator wil= l receive a message indicating the problem. > ** check if the target storage has the capacity for the new volume. If it= does not have enough space, then an exception is thrown and the operator w= ill receive a message indicating the problem. > ** check if the size of the volume is the same as the size of the new dis= k offering. If it is not the same, we will ALLOW the change of the service = offering, and a warning message will be logged. > We execute the change of the Disk offering as soon as the migration of th= e volume finishes. Therefore, if an error happens during the migration and = the volume remains in the original storage system, the disk offering will k= eep reflecting this situation -- This message was sent by Atlassian JIRA (v7.6.3#76005)