From issues-return-91054-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Fri Mar 16 16:03:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 88256180608 for ; Fri, 16 Mar 2018 16:03:04 +0100 (CET) Received: (qmail 69570 invoked by uid 500); 16 Mar 2018 15:03:03 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 69557 invoked by uid 500); 16 Mar 2018 15:03:03 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 69554 invoked by uid 99); 16 Mar 2018 15:03:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Mar 2018 15:03:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 1E260180634 for ; Fri, 16 Mar 2018 15:03:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id lAG4FiN55-71 for ; Fri, 16 Mar 2018 15:03:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 946EB5F477 for ; Fri, 16 Mar 2018 15:03:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id F0250E02F7 for ; Fri, 16 Mar 2018 15:03:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 680A921289 for ; Fri, 16 Mar 2018 15:03:00 +0000 (UTC) Date: Fri, 16 Mar 2018 15:03:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-10320) Invalid pair for response object breaking response parsing MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-10320?page=3Dcom.atl= assian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId= =3D16402011#comment-16402011 ]=20 ASF GitHub Bot commented on CLOUDSTACK-10320: --------------------------------------------- blueorangutan commented on issue #2481: CLOUDSTACK-10320 - Invalid pair for= response object breaking response parsing URL: https://github.com/apache/cloudstack/pull/2481#issuecomment-373740886 =20 =20 @rafaelweingartner a Jenkins job has been kicked to build packages. I'll= keep you posted as I make progress. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Invalid pair for response object breaking response parsing > ---------------------------------------------------------- > > Key: CLOUDSTACK-10320 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-103= 20 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the defa= ult.)=20 > Components: API > Reporter: Marc-Aur=C3=A8le Brothier > Assignee: Marc-Aur=C3=A8le Brothier > Priority: Major > > Under some circumstances, the API is returning an invalid response, for s= implicity I will expose the JSON case. The API response on a listVirtualMac= hines can be this string: > {code:java} > { "listvirtualmachinesresponse" :=C2=A0 ] } }{code} > To understand how this is possible, assume you have more than one managem= ent server and one is processing the destroy of a virtual machine in the ac= count X which is the only one it has. Another process is returning the resu= lt of listVirtualMachines for that same account X. During the listVM comman= d, the result set is fetch with a searchAndDistinctCount due to the view ([= https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/c= loud/api/query/QueryManagerImpl.java#L1024).] This is done through 2 querie= s in the GenericDao [https://github.com/apache/cloudstack/blob/master/frame= work/db/src/main/java/com/cloud/utils/db/GenericDaoBase.java#L1323] and if = you encounter the _right_ conditions, the VM will be marked as removed in b= etween those 2 queries. This results in having a Pair result with at least = one object but a count of 0. Then following how is done the serialization o= f the response at [https://github.com/apache/cloudstack/blob/master/server/= src/main/java/com/cloud/api/response/ApiResponseSerializer.java#L86] you wi= ll reach the case where your output is the one previously mentioned. > To overcome this issue, there isn't a true fix but only a better pair res= ponse to ensure a correct response formatting. If the result set contains a= t least something, the count cannot be 0 but we cannot guess the correct an= swer, but only state it has at least one element. -- This message was sent by Atlassian JIRA (v7.6.3#76005)