From issues-return-91071-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Sun Mar 18 21:02:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2046918067E for ; Sun, 18 Mar 2018 21:02:04 +0100 (CET) Received: (qmail 64580 invoked by uid 500); 18 Mar 2018 20:02:04 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 64569 invoked by uid 500); 18 Mar 2018 20:02:04 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 64566 invoked by uid 99); 18 Mar 2018 20:02:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 18 Mar 2018 20:02:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 7D90A18047E for ; Sun, 18 Mar 2018 20:02:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id JBiU1_d1Igev for ; Sun, 18 Mar 2018 20:02:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id DF6145FD10 for ; Sun, 18 Mar 2018 20:02:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0DC32E0D0B for ; Sun, 18 Mar 2018 20:02:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7B58B214A3 for ; Sun, 18 Mar 2018 20:02:00 +0000 (UTC) Date: Sun, 18 Mar 2018 20:02:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-10301) Allow updating the network ACL list name and Description MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-10301?page=3Dcom.atl= assian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId= =3D16404150#comment-16404150 ]=20 ASF GitHub Bot commented on CLOUDSTACK-10301: --------------------------------------------- DaanHoogland commented on a change in pull request #2462: [CLOUDSTACK-10301= ] Allow updating the network ACL list name and Description URL: https://github.com/apache/cloudstack/pull/2462#discussion_r175301471 =20 =20 ########## File path: server/src/test/java/com/cloud/network/vpc/NetworkACLServiceImp= lTest.java ########## @@ -64,9 +67,11 @@ @Mock private NetworkACLItemDao networkAclItemDaoMock; @Mock - private EntityManager EntityManagerMock; + private EntityManager entityManagerMock; @Mock - private AccountManager AccountManager; + private AccountManager AccountManagerMock; =20 Review comment: lower case for this var name as well? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Allow updating the network ACL list name and Description=20 > --------------------------------------------------------- > > Key: CLOUDSTACK-10301 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-103= 01 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the defa= ult.)=20 > Reporter: Rafael Weing=C3=A4rtner > Assignee: Rafael Weing=C3=A4rtner > Priority: Major > > Currently, it is not possible to update the Network ACL name or Descripti= on of an ACL after it has been created. It might be interesting to expose t= his option via API and to add this feature to the UI. -- This message was sent by Atlassian JIRA (v7.6.3#76005)