From issues-return-91599-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Thu Mar 29 13:41:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id F218A180645 for ; Thu, 29 Mar 2018 13:41:05 +0200 (CEST) Received: (qmail 12836 invoked by uid 500); 29 Mar 2018 11:41:04 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 12744 invoked by uid 500); 29 Mar 2018 11:41:03 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 12724 invoked by uid 99); 29 Mar 2018 11:41:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Mar 2018 11:41:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 57DFDC044D for ; Thu, 29 Mar 2018 11:41:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id JaTP-mQc_z9C for ; Thu, 29 Mar 2018 11:41:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B897D5F181 for ; Thu, 29 Mar 2018 11:41:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CF9E9E0E70 for ; Thu, 29 Mar 2018 11:41:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 54EAB255F4 for ; Thu, 29 Mar 2018 11:41:00 +0000 (UTC) Date: Thu, 29 Mar 2018 11:41:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-10278) Adding a SQL table column is not Idempotent MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-10278?page=3Dcom.atl= assian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId= =3D16418819#comment-16418819 ]=20 ASF GitHub Bot commented on CLOUDSTACK-10278: --------------------------------------------- DaanHoogland commented on issue #2449: CLOUDSTACK-10278 idempotent column a= ddition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-377208682 =20 =20 @rafaelweingartner the changes should be forward merged to master and i = am procastrinating that task. I see that test was not on my eyes as being unstable yet. maybe somethin= g got merged ;) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Adding a SQL table column is not Idempotent > ------------------------------------------- > > Key: CLOUDSTACK-10278 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-102= 78 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the defa= ult.)=20 > Components: Install and Setup > Affects Versions: 4.10.0.0, 4.11.0.0 > Reporter: Ernie Janse van Rensburg > Assignee: Ernie Janse van Rensburg > Priority: Major > Original Estimate: 4h > Remaining Estimate: 4h > > The SQL code to add a new=C2=A0column to a table in the META-INF/db/schem= a-41000to41100.sql script is not written in an idempotent way. When the upg= rade is=C2=A0re-run, the code above causes a SQL error as reported on the u= ser mailing list:=C2=A0 > ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:) > Error executing: ALTER TABLE cloud.network_offerings ADD COLUMN for_vpc > INT(1) NOT NULL DEFAULT 0 > This is a more generic problem for every version due to to the fact that = it is not idempotent > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)