From issues-return-90904-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Tue Mar 13 20:35:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8904B18067B for ; Tue, 13 Mar 2018 20:35:04 +0100 (CET) Received: (qmail 27146 invoked by uid 500); 13 Mar 2018 19:35:03 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 27048 invoked by uid 500); 13 Mar 2018 19:35:03 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 27045 invoked by uid 99); 13 Mar 2018 19:35:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Mar 2018 19:35:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id EEFE9C629C for ; Tue, 13 Mar 2018 19:35:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id W0UhjHB9yhdr for ; Tue, 13 Mar 2018 19:35:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D52A65F393 for ; Tue, 13 Mar 2018 19:35:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0FDFCE0CE9 for ; Tue, 13 Mar 2018 19:35:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 612EA21489 for ; Tue, 13 Mar 2018 19:35:00 +0000 (UTC) Date: Tue, 13 Mar 2018 19:35:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-10241) Duplicated file SRs being created in XenServer pools MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-10241?page=3Dcom.atl= assian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId= =3D16397517#comment-16397517 ]=20 ASF GitHub Bot commented on CLOUDSTACK-10241: --------------------------------------------- DaanHoogland commented on a change in pull request #2414: [CLOUDSTACK-10241= ] Duplicated file SRs being created in XenServer pools URL: https://github.com/apache/cloudstack/pull/2414#discussion_r174258066 =20 =20 ########## File path: plugins/hypervisors/xenserver/src/main/java/com/cloud/hyperviso= r/xenserver/resource/Xenserver625StorageProcessor.java ########## @@ -65,90 +69,181 @@ public Xenserver625StorageProcessor(final CitrixResou= rceBase resource) { super(resource); } =20 - protected boolean mountNfs(final Connection conn, final String remoteD= ir, String localDir) { + private void mountNfs(Connection conn, String remoteDir, String localD= ir) { if (localDir =3D=3D null) { localDir =3D "/var/cloud_mount/" + UUID.nameUUIDFromBytes(remo= teDir.getBytes()); } - - final String results =3D hypervisorResource.callHostPluginAsync(co= nn, "cloud-plugin-storage", "mountNfsSecondaryStorage", 100 * 1000, "localD= ir", localDir, "remoteDir", - remoteDir); - - if (results =3D=3D null || results.isEmpty()) { + String result =3D hypervisorResource.callHostPluginAsync(conn, "cl= oud-plugin-storage", "mountNfsSecondaryStorage", 100 * 1000, "localDir", lo= calDir, "remoteDir", remoteDir); =20 Review comment: ok, short method with low cyclic complexity; makes sense ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Duplicated file SRs being created in XenServer pools > ---------------------------------------------------- > > Key: CLOUDSTACK-10241 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-102= 41 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the defa= ult.)=20 > Reporter: Rafael Weing=C3=A4rtner > Assignee: Rafael Weing=C3=A4rtner > Priority: Major > > Due to a race condition between multiple management servers, in some rare= cases, CloudStack is creating multiple file SRs to the same secondary fold= er. This causes a problem when introducing the SR to the XenServer pools, a= s =E2=80=9Cthere will be VDIs with duplicated UUIDs=E2=80=9C. The VDIs are = the same, but they are seen in different SRs, and therefore cause an error. -- This message was sent by Atlassian JIRA (v7.6.3#76005)