cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10334) Inadequate information for handling catch clauses
Date Fri, 23 Mar 2018 13:59:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411421#comment-16411421
] 

ASF GitHub Bot commented on CLOUDSTACK-10334:
---------------------------------------------

lzh3636 opened a new pull request #2509: CLOUDSTACK-10334: Inadequate information for handling
catch clauses
URL: https://github.com/apache/cloudstack/pull/2509
 
 
   ## Description
   The description of the problem:
   https://issues.apache.org/jira/browse/CLOUDSTACK-10334
   I just added stack traces information to those two logging statements, so that the exception
type can be generated to the logs.
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that
apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   
   ## Checklist:
   <!--- Go over all the following points, and put an `x` in all the boxes that apply.
-->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help!
-->
   - [x] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
document.
   - [x] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   - [ ] I have added tests to cover my changes.
   - [x] All new and existing tests passed.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Inadequate information for handling catch clauses
> -------------------------------------------------
>
>                 Key: CLOUDSTACK-10334
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10334
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Zhenhao Li
>            Priority: Major
>              Labels: easyfix
>
> Their are some situations that different exception types are caught, but the handling
of those exceptions can not show the differences of those types. Here are the code snippets
we found which have this problem:
> *cloudstack/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java*
> [https://github.com/apache/cloudstack/blob/893a88d225276e45f12f9490e6af2c94a81c2965/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java]
> At Line *261* and Line *265.* We can see that two exception types are caught, but
the logging statements here can not show the exception type at all.
> Also they threw new exceptions after the logs, but the throw statements in these two
catch clauses are identical, which are not distinguishable.
> It may cause confusions to the person who is reading the log, the person can not know
what exception happened here and can not distinguish logs generated by these two statements.
>  Maybe adding stack trace information to these two logging statements and change the
log message to handle specific situations is a simple way to improve it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message