cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10310) KVM hosts reboot if there is a short transient storage error
Date Mon, 19 Mar 2018 06:04:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404408#comment-16404408
] 

ASF GitHub Bot commented on CLOUDSTACK-10310:
---------------------------------------------

rhtyd commented on a change in pull request #2472: CLOUDSTACK-10310 Fix KVM reboot on storage
issue
URL: https://github.com/apache/cloudstack/pull/2472#discussion_r175337493
 
 

 ##########
 File path: scripts/vm/hypervisor/kvm/kvmheartbeat.sh
 ##########
 @@ -155,10 +155,10 @@ then
   exit 0
 elif [ "$cflag" == "1" ]
 then
-  /usr/bin/logger -t heartbeat "kvmheartbeat.sh rebooted system because it was unable to
write the heartbeat to the storage."
+  /usr/bin/logger -t heartbeat "kvmheartbeat.sh stopped cloudstack-agent because it was unable
to write the heartbeat to the storage."
   sync &
   sleep 5
-  echo b > /proc/sysrq-trigger
+  service cloudstack-agent stop
 
 Review comment:
   Maybe you can sent the PR in two parts, the first half that increases the heartbeat retry
threshold to `5` LGTM. The second part could be the configuration fix, global setting or setting
in agent.properties to decide whether to reboot kvm host or stop agent.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> KVM hosts reboot if there is a short transient storage error
> ------------------------------------------------------------
>
>                 Key: CLOUDSTACK-10310
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10310
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: KVM
>    Affects Versions: 4.9.0, 4.10.0.0
>            Reporter: Sean Lair
>            Priority: Major
>
> If the KVM heartbeat file can't be written to, the host is rebooted, and thus taking
down all VMs running on it.  The code does try 5x times before the reboot, but the there
is not a delay between the retires, so they are 5 simultaneous retries, which doesn't help. 
Standard SAN storage HA operations or quick network blip could cause this reboot to occur.
> Some discussions on the dev mailing list revealed that some people are just commenting
out the reboot line in their version of the CloudStack source.
> A better option (and a new PR is being issued) would be have it sleep between tries so
it isn't 5x almost simultaneous tries.  Plus, instead of rebooting, the cloudstack-agent
could just be stopped on the host instead.  This will cause alerts to be issued and if the
host is disconnected long-enough, depending on the HA code in use, VM HA could handle the
host failure.
> The built-in reboot of the host seemed drastic



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message