cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10278) Adding a SQL table column is not Idempotent
Date Wed, 28 Mar 2018 10:51:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417155#comment-16417155
] 

ASF GitHub Bot commented on CLOUDSTACK-10278:
---------------------------------------------

ernjvr commented on issue #2449: CLOUDSTACK-10278 idempotent column addition
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-376842088
 
 
   Upgrade Test Result: I installed a version 4.6 environment with some of the DB changes
that were already in 4.11, created a few networks: isolated, shared, vpc and created vms on
each. I proceeded with the upgrade to 4.11 using this PR code. After the upgrade i had to
add missing braces to some environment variables in the /usr/lib/systemd/system/cloudstack-management.service
file and also had to configure the /etc/default/cloudstack-management file with the correct
4.11 environment variables. After starting the management server and running the migrate-dynamicroles.py
I was able to log in to the UI and observe that the vms were back up and running. A successful
upgrade without any DB issues.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Adding a SQL table column is not Idempotent
> -------------------------------------------
>
>                 Key: CLOUDSTACK-10278
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10278
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Install and Setup
>    Affects Versions: 4.10.0.0, 4.11.0.0
>            Reporter: Ernie Janse van Rensburg
>            Assignee: Ernie Janse van Rensburg
>            Priority: Major
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The SQL code to add a new column to a table in the META-INF/db/schema-41000to41100.sql
script is not written in an idempotent way. When the upgrade is re-run, the code above causes
a SQL error as reported on the user mailing list: 
> ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:)
> Error executing: ALTER TABLE cloud.network_offerings ADD COLUMN for_vpc
> INT(1) NOT NULL DEFAULT 0
> This is a more generic problem for every version due to to the fact that it is not idempotent
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message