From issues-return-90192-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Wed Feb 21 13:02:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A99B918061A for ; Wed, 21 Feb 2018 13:02:05 +0100 (CET) Received: (qmail 5152 invoked by uid 500); 21 Feb 2018 12:02:04 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 5143 invoked by uid 500); 21 Feb 2018 12:02:04 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 5140 invoked by uid 99); 21 Feb 2018 12:02:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Feb 2018 12:02:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 38C271A0A3A for ; Wed, 21 Feb 2018 12:02:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id yMvg9jga05bp for ; Wed, 21 Feb 2018 12:02:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 75DC75F58B for ; Wed, 21 Feb 2018 12:02:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 907A9E0254 for ; Wed, 21 Feb 2018 12:02:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 400872108C for ; Wed, 21 Feb 2018 12:02:00 +0000 (UTC) Date: Wed, 21 Feb 2018 12:02:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-10299) Network listing return error in project mode MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-10299?page=3Dcom.atl= assian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId= =3D16371290#comment-16371290 ]=20 ASF GitHub Bot commented on CLOUDSTACK-10299: --------------------------------------------- rafaelweingartner commented on a change in pull request #2464: [4.11] CLOUD= STACK-10299: UI: fix error in network listing in project mode URL: https://github.com/apache/cloudstack/pull/2464#discussion_r169616063 =20 =20 ########## File path: ui/scripts/network.js ########## @@ -3537,28 +3535,28 @@ var lbID =3D data.= createloadbalancerruleresponse.id; =20 var inputData =3D = { - =09id: data.create= loadbalancerruleresponse.id=09 - }; =20 - =20 + =09id: data.create= loadbalancerruleresponse.id + }; + var selectedVMs = =3D args.itemData; if (selectedVMs != =3D null) { =09var vmidipmapIn= dex =3D 0; - =09=09for (var vmIndex= =3D 0; vmIndex < selectedVMs.length; vmIndex++) { =20 + =09=09for (var vmIndex= =3D 0; vmIndex < selectedVMs.length; vmIndex++) { =09=09=09var selectedI= Ps =3D selectedVMs[vmIndex]._subselect; =09=09=09for (var ipIn= dex =3D 0; ipIndex < selectedIPs.length; ipIndex++) { =09=09=09=09inputData[= 'vmidipmap[' + vmidipmapIndex + '].vmid'] =3D selectedVMs[vmIndex].id; - =09=09=09 + =09=09=09=09if (args.c= ontext.ipAddresses[0].isportable) { - =09=09=09 input= Data['vmidipmap[' + vmidipmapIndex + '].vmip'] =3D selectedIPs[ipIndex].spl= it(',')[1]; =20 + =09=09=09 input= Data['vmidipmap[' + vmidipmapIndex + '].vmip'] =3D selectedIPs[ipIndex].spl= it(',')[1]; =09=09=09} else { =09=09=09=09inputD= ata['vmidipmap[' + vmidipmapIndex + '].vmip'] =3D selectedIPs[ipIndex]; =09=09=09} - =09=09=09=09 + =09=09=09=09vmidipmapI= ndex++; - =09=09=09} = =09=09=09 + =09=09=09} =09=09} - =09} =20 - =20 + =09} + /*$.ajax({ =20 Review comment: Well.. the commented code is not used. So, there is your reason to remov= e it. The less "code" (lines) for our eyes to see, the better. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Network listing return error in project mode > -------------------------------------------- > > Key: CLOUDSTACK-10299 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-102= 99 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the defa= ult.)=20 > Components: UI > Affects Versions: 4.11.0.0 > Reporter: Ren=C3=A9 Moser > Priority: Minor > Attachments: Selection_142.png > > > {{Clicking the network button in a project returns the following error:}} > =C2=A0 > {{{"listremoteaccessvpnsresponse":{"uuidList":[],"errorcode":431,"cserror= code":4350,"errortext":"Account}}{{ and projectId can't be specified togeth= er"}}}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)