From issues-return-89938-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Mon Feb 12 12:07:06 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 0F642180652 for ; Mon, 12 Feb 2018 12:07:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id F35D5160C31; Mon, 12 Feb 2018 11:07:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1F8B9160C3F for ; Mon, 12 Feb 2018 12:07:04 +0100 (CET) Received: (qmail 8829 invoked by uid 500); 12 Feb 2018 11:07:04 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 8820 invoked by uid 500); 12 Feb 2018 11:07:04 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 8817 invoked by uid 99); 12 Feb 2018 11:07:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Feb 2018 11:07:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 686381A01BB for ; Mon, 12 Feb 2018 11:07:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id aKV5UDTme5G4 for ; Mon, 12 Feb 2018 11:07:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B20C05F640 for ; Mon, 12 Feb 2018 11:07:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CDE1AE01BE for ; Mon, 12 Feb 2018 11:07:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 38965240F6 for ; Mon, 12 Feb 2018 11:07:00 +0000 (UTC) Date: Mon, 12 Feb 2018 11:07:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-10261) Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one interface. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360595#comment-16360595 ] ASF GitHub Bot commented on CLOUDSTACK-10261: --------------------------------------------- rhtyd closed pull request #2441: CLOUDSTACK-10261: Libvirt metadata: only create one nuage-extension tag URL: https://github.com/apache/cloudstack/pull/2441 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java index 385fe79ef2a..90674eb99a8 100644 --- a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java +++ b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java @@ -1543,16 +1543,15 @@ public void addNuageExtension(String macAddress, String vrIp) { @Override public String toString() { StringBuilder fsBuilder = new StringBuilder(); + fsBuilder.append("\n"); for (Map.Entry address : addresses.entrySet()) { - fsBuilder.append("\n") - .append(" \n") - .append("\n"); + fsBuilder.append(" \n"); } - return fsBuilder.toString(); + return fsBuilder.append("\n").toString(); } } diff --git a/plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java b/plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java index 006562c213e..b391b94e740 100644 --- a/plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java +++ b/plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java @@ -209,4 +209,21 @@ public void testSCSIDef() { assertEquals(str, expected); } + public void testMetadataDef() { + LibvirtVMDef.MetadataDef metadataDef = new LibvirtVMDef.MetadataDef(); + + metadataDef.getMetadataNode(LibvirtVMDef.NuageExtensionDef.class).addNuageExtension("mac1", "ip1"); + metadataDef.getMetadataNode(LibvirtVMDef.NuageExtensionDef.class).addNuageExtension("mac2", "ip2"); + + String xmlDef = metadataDef.toString(); + String expectedXml = "\n" + + "\n" + + " \n" + + " \n" + + "\n" + + "\n"; + + assertEquals(xmlDef, expectedXml); + } + } ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one interface. > ------------------------------------------------------------------------------- > > Key: CLOUDSTACK-10261 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10261 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Components: cloudstack-agent > Affects Versions: 4.11.0.0 > Environment: Nuage VSP plugin on RHEL 7.4 > Reporter: Frank Maximus > Assignee: Frank Maximus > Priority: Critical > Fix For: 4.11.0.0 > > > When installed ACS 4.11 on top of Rhel7.4 baseimage with libvirt-3.2.0 ,there is an issue with the metadata of the created VM in cloudstack. > It leads to password reset failure as the nuage vrs is not allowing passage to DomainRouter. > After debugging , it was found that the nuage-extension in metadata was missing. > When cloudstack-agent is preparing xml to be sent to openvswitch it contains metadata with nuage-extension block as follows > > > > > > In /var/log/openvswitch/vm-monitor.log , the received XML of VM is without nuage-extension block in metadata as follows: > Jan 15 18:17:17 ovs-1 vm-monitor.log: > So the metadata block is now empty. It seems libvirt 3.2.0 requires an url in its metada, so the libvirt namespace needs to be adapted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)