From issues-return-90227-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Thu Feb 22 17:01:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DD60518067E for ; Thu, 22 Feb 2018 17:01:05 +0100 (CET) Received: (qmail 95517 invoked by uid 500); 22 Feb 2018 16:01:04 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 95508 invoked by uid 500); 22 Feb 2018 16:01:04 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 95505 invoked by uid 99); 22 Feb 2018 16:01:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Feb 2018 16:01:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 57D6E180453 for ; Thu, 22 Feb 2018 16:01:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 4tRRSibcB1DL for ; Thu, 22 Feb 2018 16:01:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B30905FB93 for ; Thu, 22 Feb 2018 16:01:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id F127BE021F for ; Thu, 22 Feb 2018 16:01:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 712CC2712D for ; Thu, 22 Feb 2018 16:01:00 +0000 (UTC) Date: Thu, 22 Feb 2018 16:01:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-10232) SystemVMs and VR to run as HVM on XenServer MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372981#comment-16372981 ] ASF GitHub Bot commented on CLOUDSTACK-10232: --------------------------------------------- rhtyd commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer URL: https://github.com/apache/cloudstack/pull/2465#discussion_r170005233 ########## File path: systemvm/debian/opt/cloud/bin/setup/cloud-early-config ########## @@ -42,7 +42,14 @@ hypervisor() { grep -q QEMU /var/log/messages && echo "kvm" && return 0 [ -d /proc/xen ] && mount -t xenfs none /proc/xen - [ -d /proc/xen ] && echo "xen-domU" && return 0 + if [ -d /proc/xen ]; then + `dmesg | grep -q "Xen HVM"` Review comment: For consistency, can you use this instead $(command here)? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > SystemVMs and VR to run as HVM on XenServer > ------------------------------------------- > > Key: CLOUDSTACK-10232 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10232 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the default.) > Components: SystemVM, Virtual Router, XenServer > Affects Versions: 4.10.0.0, 4.9.3.0 > Reporter: Pierre-Luc Dion > Priority: Major > > Following the recent Meltdown-Spectre security risk,one of the mitigation,as of Jan 2018, for XenServer Hypervisor is to run Virtual-Machine in HVM mode. > Currently SystemVMs and Virtual-Routers run as PV on XenServer and the eth0 is configured using {{/etc/init.d/cloud-early-config}} using grub params from {{/proc/cmdline}}. When VM run as HVM, it is not possible to push initial boot instruction via pygrub. > Quick tests has been done using xenstore and it look like it would be possible to send same initial boot instruction has pygrub but using xenstore for HVM instances. -- This message was sent by Atlassian JIRA (v7.6.3#76005)