cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10278) Adding a SQL table column is not Idempotent
Date Wed, 14 Feb 2018 14:22:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364112#comment-16364112
] 

ASF GitHub Bot commented on CLOUDSTACK-10278:
---------------------------------------------

ernjvr commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-365621097
 
 
   @borisstoyanov yes, it's the way com/cloud/utils/db/ScriptRunner.java reads the META-INF/db/schema-41000to41100.sql
file. It reads each line at a time and executes the sql as soon as it reads in a line that
ends with a semicolon delimeter at the end. my stored procedure had many lines ending with
semicolons. So it executed an incomplete stored procedure definition. I fixed by moving all
lines that end with a semicolon onto one line, so that it can read in and execute the whole
stored proc definition.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Adding a SQL table column is not Idempotent
> -------------------------------------------
>
>                 Key: CLOUDSTACK-10278
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10278
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Install and Setup
>    Affects Versions: 4.10.0.0, 4.11.0.0
>            Reporter: Ernie Janse van Rensburg
>            Assignee: Ernie Janse van Rensburg
>            Priority: Major
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The SQL code to add a new column to a table in the META-INF/db/schema-41000to41100.sql
script is not written in an idempotent way. When the upgrade is re-run, the code above causes
a SQL error as reported on the user mailing list: 
> ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:)
> Error executing: ALTER TABLE cloud.network_offerings ADD COLUMN for_vpc
> INT(1) NOT NULL DEFAULT 0
> This is a more generic problem for every version due to to the fact that it is not idempotent
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message