cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10039) Adding IOPS/GB offering
Date Fri, 23 Feb 2018 19:53:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374905#comment-16374905
] 

ASF GitHub Bot commented on CLOUDSTACK-10039:
---------------------------------------------

syed commented on a change in pull request #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering
URL: https://github.com/apache/cloudstack/pull/2231#discussion_r170351240
 
 

 ##########
 File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
 ##########
 @@ -2566,6 +2567,61 @@ protected DiskOfferingVO createDiskOffering(final Long userId, final
Long domain
             isCustomized = true;
         }
 
+        if (minIopsPerGb != null || maxIopsPerGb != null) {
+
+            if (!isCustomized) {
+               throw new InvalidParameterValueException("Cannot set Min/Max IOPS/GB for a
fixed size disk offering");
 
 Review comment:
   You cannot have an IOPS/GB offering for a fixed sized disk. The whole Idea of an IOPS/GB
type of offering makes sense when you have a custom offering so when you change the size of
a disk, the IOPS also change

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Adding IOPS/GB offering
> -----------------------
>
>                 Key: CLOUDSTACK-10039
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10039
>             Project: CloudStack
>          Issue Type: New Feature
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Storage Controller
>            Reporter: Syed Ahmed
>            Priority: Major
>             Fix For: Future
>
>
> We want to add a disk offering where we can specify the Min/Max IOPS as a function of
size. The idea is the larger volume you create, the greater your IOPS will be (this is similar
to the way GCE handles IOPS). We also have added limits to the IOPS (min and max) so that
once the volume goes beyond a certain size, the IOPS won't change and are capped to the given
values.
> The following parameters are added to the `createDiskOffering` API:
> 1. `miniopspergb' : Minimum IOPS/GB for the offering
> 2. `maxiopspergb`: Maximum IOPS/GB for the offering
> 3. `highestminiops`: The highest `miniops` value that is allowed for this offering
> 3. `highestmaxiops`: The highest `maxiops` value that is allowed for this offering



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message