From issues-return-89402-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Wed Jan 24 16:21:08 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 06A29180630 for ; Wed, 24 Jan 2018 16:21:08 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id EBA97160C3C; Wed, 24 Jan 2018 15:21:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3C733160C2E for ; Wed, 24 Jan 2018 16:21:07 +0100 (CET) Received: (qmail 87552 invoked by uid 500); 24 Jan 2018 15:21:06 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 87543 invoked by uid 500); 24 Jan 2018 15:21:06 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 87540 invoked by uid 99); 24 Jan 2018 15:21:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Jan 2018 15:21:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id DD613C0CB5 for ; Wed, 24 Jan 2018 15:21:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -107.911 X-Spam-Level: X-Spam-Status: No, score=-107.911 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id wDrHpnx-Q3Wm for ; Wed, 24 Jan 2018 15:21:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 73D7D5F3A1 for ; Wed, 24 Jan 2018 15:21:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 04BCAE041F for ; Wed, 24 Jan 2018 15:21:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2E9AB240FA for ; Wed, 24 Jan 2018 15:21:00 +0000 (UTC) Date: Wed, 24 Jan 2018 15:21:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-10255) cloudstack-agent logrotate is broken MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337749#comment-16337749 ] ASF GitHub Bot commented on CLOUDSTACK-10255: --------------------------------------------- blueorangutan commented on issue #2429: CLOUDSTACK-10255: Fix agent logrotate URL: https://github.com/apache/cloudstack/pull/2429#issuecomment-360168288 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > cloudstack-agent logrotate is broken > ------------------------------------ > > Key: CLOUDSTACK-10255 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10255 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Components: cloudstack-agent > Affects Versions: 4.10.0.0, 4.11.0.0, 4.9.3.0 > Reporter: Frank Maximus > Assignee: Frank Maximus > Priority: Major > > In [PR#2094|https://github.com/apache/cloudstack/pull/2094] logrotate was updated to refer to the new files, and an {{@AGENTLOG@}} ReplaceToken was used. > The pom file of agent doesn't define {{cloudstack-agent.logrotate}} to be filtered though, so the file ends up on the host, still containting the ReplaceToken. > {noformat:title=KVM Host}You have new mail in /var/spool/mail/root > [root@frank-acs-master ~]# mail > Heirloom Mail version 12.5 7/5/10. Type ? for help. > "/var/spool/mail/root": 7 messages 7 new > >N 1 Anacron Thu Jan 18 15:36 17/727 "Anacron job 'cron.daily' on frank-acs-master" > N 2 Anacron Fri Jan 19 03:50 17/729 "Anacron job 'cron.daily' on frank-acs-master" > N 3 Anacron Sat Jan 20 03:30 17/729 "Anacron job 'cron.daily' on frank-acs-master" > N 4 Anacron Sun Jan 21 03:25 17/729 "Anacron job 'cron.daily' on frank-acs-master" > N 5 Anacron Mon Jan 22 03:39 17/729 "Anacron job 'cron.daily' on frank-acs-master" > N 6 Anacron Tue Jan 23 03:10 17/729 "Anacron job 'cron.daily' on frank-acs-master" > N 7 Anacron Wed Jan 24 03:23 17/729 "Anacron job 'cron.daily' on frank-acs-master" > & 7 > Message 7: > From root@frank-acs-master.localdomain Wed Jan 24 03:23:03 2018 > Return-Path: > X-Original-To: root > Delivered-To: root@frank-acs-master.localdomain > From: Anacron > To: root@frank-acs-master.localdomain > Content-Type: text/plain; charset="UTF-8" > Subject: Anacron job 'cron.daily' on frank-acs-master > Date: Wed, 24 Jan 2018 03:23:03 +0000 (UTC) > Status: R > /etc/cron.daily/logrotate: > error: cloudstack-agent:18 lines must begin with a keyword or a filename (possibly in double quotes) > & q > [root@frank-acs-master ~]# cat /etc/logrotate.d/cloudstack-agent > # Licensed to the Apache Software Foundation (ASF) under .... the License. > @AGENTLOG@ > /var/log/cloudstack/agent/security_group.log > { > copytruncate > daily > rotate 5 > compress > missingok > } > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)