From issues-return-88977-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Wed Jan 10 21:17:06 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id E9F4518072F for ; Wed, 10 Jan 2018 21:17:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D985A160C2E; Wed, 10 Jan 2018 20:17:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2DBB3160C1E for ; Wed, 10 Jan 2018 21:17:05 +0100 (CET) Received: (qmail 38966 invoked by uid 500); 10 Jan 2018 20:17:04 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 38957 invoked by uid 500); 10 Jan 2018 20:17:04 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 38954 invoked by uid 99); 10 Jan 2018 20:17:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jan 2018 20:17:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id A83AF180414 for ; Wed, 10 Jan 2018 20:17:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -107.911 X-Spam-Level: X-Spam-Status: No, score=-107.911 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id ZW6yowMtpm5w for ; Wed, 10 Jan 2018 20:17:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 2B8815F36C for ; Wed, 10 Jan 2018 20:17:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 71EF4E0F55 for ; Wed, 10 Jan 2018 20:17:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2736E274D6 for ; Wed, 10 Jan 2018 20:17:01 +0000 (UTC) Date: Wed, 10 Jan 2018 20:17:01 +0000 (UTC) From: "Daan Hoogland (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (CLOUDSTACK-10225) Deprecate com.cloud.utils.StringUtils MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320980#comment-16320980 ] Daan Hoogland edited comment on CLOUDSTACK-10225 at 1/10/18 8:16 PM: --------------------------------------------------------------------- not sure how to create a checklist in jira but here's a start (+) join(final String delimiter, final Object... components) is a wrapper of the commons method with only a reverse of the parameters. (+) join(final Iterable iterable, final String delim) can be replaced withpout change (+) isNotBlank() could be replaced by ! isBlank() except for a small semantic differnce; a string consisting of whitespace character like " \t\n" would be returning true instead of false (-) cleanupTags(String tags) is a true utility that is specific to the way we implement tagging was (Author: dahn): not sure how to create a checklist in jira but here's a start (+) join(final String delimiter, final Object... components) is a wrapper of the commons method with only a reverse of the parameters. (+) join(final Iterable iterable, final String delim) can be replaced withpout change (+) isNotBlank() could be replaced by ! isBlank() except for a small semantic differnce; a string consisting of whitespace character like " \t\n" would be returning true instead of false > Deprecate com.cloud.utils.StringUtils > ------------------------------------- > > Key: CLOUDSTACK-10225 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10225 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the default.) > Reporter: Wido den Hollander > > com.cloud.utils.StringUtils contains a lot of methods which can be deprecated in favor of Apache Commons. > We should try to use Apache Commons where possible and reduce our code footprint. -- This message was sent by Atlassian JIRA (v6.4.14#64029)