From issues-return-88780-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Tue Jan 9 07:47:13 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 3AEB9180718 for ; Tue, 9 Jan 2018 07:47:13 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 2AE9E160C2D; Tue, 9 Jan 2018 06:47:13 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 70A81160C13 for ; Tue, 9 Jan 2018 07:47:12 +0100 (CET) Received: (qmail 73432 invoked by uid 500); 9 Jan 2018 06:47:11 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 73423 invoked by uid 500); 9 Jan 2018 06:47:11 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 73420 invoked by uid 99); 9 Jan 2018 06:47:11 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Jan 2018 06:47:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 22B92C0E3C for ; Tue, 9 Jan 2018 06:47:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.911 X-Spam-Level: X-Spam-Status: No, score=-99.911 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id awH0ROGDMmxp for ; Tue, 9 Jan 2018 06:47:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id CFBA05FB87 for ; Tue, 9 Jan 2018 06:47:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 124A5E041F for ; Tue, 9 Jan 2018 06:47:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 77590240EA for ; Tue, 9 Jan 2018 06:47:03 +0000 (UTC) Date: Tue, 9 Jan 2018 06:47:03 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-10213) Allow specify SSH key lengh MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-10213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317839#comment-16317839 ] ASF GitHub Bot commented on CLOUDSTACK-10213: --------------------------------------------- rhtyd commented on issue #2389: CLOUDSTACK-10213: Allow specify SSH key lengh URL: https://github.com/apache/cloudstack/pull/2389#issuecomment-356195148 Tests ltgm, merging this based on code reviews and tests. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Allow specify SSH key lengh > --------------------------- > > Key: CLOUDSTACK-10213 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10213 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the default.) > Reporter: Dmytro Shevchenko > > SSH keys generated by the ACS are only 1024 bit (RSA). The common standard is now at least 2048 bit. > decompiled com.jcraft.jsch.KeyPair: > {code:java} > public static KeyPair genKeyPair(JSch jsch, int type) throws JSchException { > return genKeyPair(jsch, type, 1024); > } > public static KeyPair genKeyPair(JSch jsch, int type, int key_size) throws JSchException { > KeyPair kpair = null; > .... > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)