From issues-return-89232-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Fri Jan 19 09:12:11 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id AC079180607 for ; Fri, 19 Jan 2018 09:12:11 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9C656160C28; Fri, 19 Jan 2018 08:12:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DE9F4160C27 for ; Fri, 19 Jan 2018 09:12:10 +0100 (CET) Received: (qmail 17986 invoked by uid 500); 19 Jan 2018 08:12:09 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 17977 invoked by uid 500); 19 Jan 2018 08:12:09 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 17974 invoked by uid 99); 19 Jan 2018 08:12:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Jan 2018 08:12:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 70A57C0C35 for ; Fri, 19 Jan 2018 08:12:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.911 X-Spam-Level: X-Spam-Status: No, score=-99.911 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 4jFcu2hyN5Sk for ; Fri, 19 Jan 2018 08:12:08 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 9D9BF5F47F for ; Fri, 19 Jan 2018 08:12:07 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CB585E0F75 for ; Fri, 19 Jan 2018 08:12:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id DA59F241C7 for ; Fri, 19 Jan 2018 08:12:03 +0000 (UTC) Date: Fri, 19 Jan 2018 08:12:03 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-9749) cloudstack master vpc_internal_lb feature is broken as port 8080 is in use by password server on lb VM MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-9749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331874#comment-16331874 ] ASF GitHub Bot commented on CLOUDSTACK-9749: -------------------------------------------- rhtyd closed pull request #2409: CLOUDSTACK-9749: Fix Password server running on internal LB VM URL: https://github.com/apache/cloudstack/pull/2409 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/systemvm/debian/opt/cloud/bin/cs/CsAddress.py b/systemvm/debian/opt/cloud/bin/cs/CsAddress.py index 6ad50459b57..8b68f538fa4 100755 --- a/systemvm/debian/opt/cloud/bin/cs/CsAddress.py +++ b/systemvm/debian/opt/cloud/bin/cs/CsAddress.py @@ -549,10 +549,21 @@ def post_config_change(self, method): self.fw_router() self.fw_vpcrouter() + cmdline = self.config.cmdline() + # On deletion nw_type will no longer be known if self.get_type() in ('guest'): if self.config.is_vpc() or self.config.is_router(): CsDevice(self.dev, self.config).configure_rp() + + # If redundant then this is dealt with + # by the master backup functions + if not cmdline.is_redundant(): + if method == "add": + CsPasswdSvc(self.address['public_ip']).start() + elif method == "delete": + CsPasswdSvc(self.address['public_ip']).stop() + logging.error( "Not able to setup source-nat for a regular router yet") @@ -564,11 +575,6 @@ def post_config_change(self, method): app = CsApache(self) app.setup() - cmdline = self.config.cmdline() - # If redundant then this is dealt with by the master backup functions - if self.get_type() in ["guest"] and not cmdline.is_redundant(): - pwdsvc = CsPasswdSvc(self.address['public_ip']).start() - if self.get_type() == "public" and self.config.is_vpc() and method == "add": if self.address["source_nat"]: vpccidr = cmdline.get_vpccidr() ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > cloudstack master vpc_internal_lb feature is broken as port 8080 is in use by password server on lb VM > ------------------------------------------------------------------------------------------------------ > > Key: CLOUDSTACK-9749 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9749 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Affects Versions: 4.10.0.0, 4.9.2.0, 4.8.2.0, 4.11.0.0 > Reporter: Raf Smeets > Assignee: Frank Maximus > Priority: Critical > Fix For: 4.10.0.0 > > Attachments: runinfo.txt > > > cloudstack master vpc_internal_lb feature is broken as port 8080 is in use by password server on lb VM > Executed test/integration/plugins/nuagevsp/test_nuage_vpc_internal_lb.py which failed in test_05_nuage_internallb_traffic at the point where it is checking the lb via wget of file using port 8080. > As port 8080 already is occupied by the password_server, it fails. > I have added the runinfo.txt of the failing test to this bugticket. > Similar issue was reported internally via CLOUD-972. -- This message was sent by Atlassian JIRA (v7.6.3#76005)