From issues-return-88515-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Sat Jan 6 18:33:08 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 953E318062C for ; Sat, 6 Jan 2018 18:33:08 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 85473160C19; Sat, 6 Jan 2018 17:33:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BFF0F160C3C for ; Sat, 6 Jan 2018 18:33:07 +0100 (CET) Received: (qmail 97687 invoked by uid 500); 6 Jan 2018 17:33:06 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 97678 invoked by uid 500); 6 Jan 2018 17:33:06 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 97675 invoked by uid 99); 6 Jan 2018 17:33:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 06 Jan 2018 17:33:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 5B14B1A0492 for ; Sat, 6 Jan 2018 17:33:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.911 X-Spam-Level: X-Spam-Status: No, score=-99.911 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 5AQsvikibb6q for ; Sat, 6 Jan 2018 17:33:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 7552F5FB29 for ; Sat, 6 Jan 2018 17:33:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8A50CE0F6E for ; Sat, 6 Jan 2018 17:33:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2449A240F2 for ; Sat, 6 Jan 2018 17:33:02 +0000 (UTC) Date: Sat, 6 Jan 2018 17:33:02 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-9730) [VMware] Unable to add a host with space in its name to existing VMware cluster MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16314759#comment-16314759 ] ASF GitHub Bot commented on CLOUDSTACK-9730: -------------------------------------------- rhtyd commented on a change in pull request #1891: CLOUDSTACK-9730: [VMware] Unable to add a host with space in its name to existing VMware cluster URL: https://github.com/apache/cloudstack/pull/1891#discussion_r160030725 ########## File path: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java ########## @@ -151,16 +151,8 @@ public VmwareServerDiscoverer() { clusterDetails.put("password", password); _clusterDetailsDao.persist(clusterId, clusterDetails); } - String updatedInventoryPath = validateCluster(url, vmwareDc); - try { - if (!URLDecoder.decode(url.getPath(), "UTF-8").equals(updatedInventoryPath)) { - // If url from API doesn't specify DC then update url in database with DC associated with this zone. - clusterDetails.put("url", url.getScheme() + "://" + url.getHost() + updatedInventoryPath); - _clusterDetailsDao.persist(clusterId, clusterDetails); Review comment: @sureshanaparti could not persisting the url in the cluster details cause regression? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > [VMware] Unable to add a host with space in its name to existing VMware cluster > ------------------------------------------------------------------------------- > > Key: CLOUDSTACK-9730 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9730 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Components: VMware > Reporter: Suresh Kumar Anaparti > Assignee: Suresh Kumar Anaparti > Fix For: 4.10.1.0 > > > ISSUE > ================== > Unable to add a host with space in the name to existing VMware cluster. > While adding host, CloudStack tries to persist the validated inventory url path in database, which inserts encoded url into database which means whitespace would be stored as '+' symbols. Url from API parameter string is being converted to URI object as part of validation, where the url path is getting encoded. -- This message was sent by Atlassian JIRA (v6.4.14#64029)