From issues-return-89474-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Sat Jan 27 10:17:04 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id DB08C18065B for ; Sat, 27 Jan 2018 10:17:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id CAFBF160C30; Sat, 27 Jan 2018 09:17:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1EFE7160C2F for ; Sat, 27 Jan 2018 10:17:03 +0100 (CET) Received: (qmail 97072 invoked by uid 500); 27 Jan 2018 09:17:03 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 97063 invoked by uid 500); 27 Jan 2018 09:17:03 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 97060 invoked by uid 99); 27 Jan 2018 09:17:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 27 Jan 2018 09:17:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8FD3CC0B96 for ; Sat, 27 Jan 2018 09:17:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.51 X-Spam-Level: X-Spam-Status: No, score=-109.51 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id iyXq8i0FJCB2 for ; Sat, 27 Jan 2018 09:17:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id AADE85FAF3 for ; Sat, 27 Jan 2018 09:17:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 3A359E00B3 for ; Sat, 27 Jan 2018 09:17:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7DEB321301 for ; Sat, 27 Jan 2018 09:17:00 +0000 (UTC) Date: Sat, 27 Jan 2018 09:17:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=3Dcom.atla= ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId= =3D16342049#comment-16342049 ]=20 ASF GitHub Bot commented on CLOUDSTACK-9677: -------------------------------------------- rafaelweingartner commented on a change in pull request #2412: CLOUDSTACK-9= 677: Adding storage policy support for swift as secondary=E2=80=A6 URL: https://github.com/apache/cloudstack/pull/2412#discussion_r164267865 =20 =20 ########## File path: utils/src/main/java/com/cloud/utils/SwiftUtil.java ########## @@ -294,12 +238,80 @@ public static String calculateRFC2104HMAC(String dat= a, String key) =20 } =20 - public static String toHexString(byte[] bytes) { + static String toHexString(byte[] bytes) { =20 Review comment: What about using a commons to convert the string to Hexadecimal? Something like: org.apache.commons.codec.binary.Hex.encode(byte[]) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Swift Storage Policy support for Secondary Storage > -------------------------------------------------- > > Key: CLOUDSTACK-9677 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-967= 7 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the defa= ult.)=20 > Reporter: Patrick D. > Assignee: Patrick D. > Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)