cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10252) VR Problem on Releasing Expunged Instance IP from dnsmasq.leases file
Date Wed, 24 Jan 2018 08:19:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337113#comment-16337113
] 

ASF GitHub Bot commented on CLOUDSTACK-10252:
---------------------------------------------

rhtyd commented on a change in pull request #2427: CLOUDSTACK-10252: Delete dnsmasq leases
file on restart
URL: https://github.com/apache/cloudstack/pull/2427#discussion_r163477509
 
 

 ##########
 File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
 ##########
 @@ -49,15 +49,21 @@ def process(self):
             self.add(self.dbag[item])
         self.write_hosts()
 
-        if self.cloud.is_changed():
-            self.delete_leases()
-
         self.configure_server()
 
-        restart_dnsmasq = self.conf.commit()
-        self.cloud.commit()
+        restart_dnsmasq = False
+
+        if self.conf.commit():
+            restart_dnsmasq = True
+
+        if self.cloud.commit():
 
 Review comment:
   @resmo The commit is called on two different files, it's the same old code refactored differently.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> VR Problem on Releasing Expunged Instance IP from dnsmasq.leases file
> ---------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-10252
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10252
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Rohit Yadav
>            Assignee: Rohit Yadav
>            Priority: Blocker
>             Fix For: 4.11.0.0
>
>
> Email on dev@:
> Hi;
> Today we noticed that one of our new provisioned instance did not get IP
> from VR. When we dig into the issue we find that one different mac is
> written in dnsmasq.leases file holds new instances IP address.
> We checked this mac address from db and we noticed that this mac is used
> for old expunged instance.
> So from this point we realised that when we destroy an instance its mac did
> not removed from dnsmasq.leases file so if we use this ip for a new
> instance then we have a problem, our instance could not get IP from VR.
> We have one host on our lab environment and its Ubuntu 16.04.3 KVM. Today
> we made a HA test and we crashed the host so VR and SystemVM's are rebooted
> after we boot host back. I do not think this issue is related to VR reboot
> but i like to give information about our environment.
> We need to manage dnsmasq.leases file when we expunge an instance.
> Thanks
> Özhan



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message